lix-community/nix-security-tracker
0
0
Fork 0
Code Issues 94 Pull requests 9 Projects Releases Packages Wiki Activity

feat: instant package removal #423

Merged
erictapen merged 2 commits from instant-package-removal into main 2024-12-07 00:03:08 +00:00
Conversation 7 Commits 2 Files changed 4 +40 -14
erictapen commented 2024-12-05 15:52:21 +00:00 (Migrated from github.com)
Copy link

Depends on #422 as I refactored some stuff there.

Closes #411

Depends on #422 as I refactored some stuff there. Closes #411
fricklerhandwerk commented 2024-12-06 00:58:57 +00:00 (Migrated from github.com)
Copy link

Draft until #422 is sorted out

Draft until #422 is sorted out
fricklerhandwerk (Migrated from github.com) reviewed 2024-12-06 10:03:20 +00:00
src/website/webview/templates/components/suggestion.html
fricklerhandwerk (Migrated from github.com) commented 2024-12-06 10:03:20 +00:00
Copy link

Doesn't this disable the scriptless workflow?

Doesn't this disable the scriptless workflow?
erictapen (Migrated from github.com) reviewed 2024-12-06 10:06:14 +00:00
src/website/webview/templates/components/suggestion.html
erictapen (Migrated from github.com) commented 2024-12-06 10:06:14 +00:00
Copy link

Yeah thats right. From the commit message:

This means that no-JS users will need to commit a status change when
removing packages, but at least that fact should be communicated well as
the page never reloads on package removal.

Yeah thats right. From the commit message: > This means that no-JS users will need to commit a status change when removing packages, but at least that fact should be communicated well as the page never reloads on package removal.
fricklerhandwerk (Migrated from github.com) reviewed 2024-12-06 10:24:06 +00:00
src/website/webview/templates/components/suggestion.html
fricklerhandwerk (Migrated from github.com) commented 2024-12-06 10:24:06 +00:00
Copy link

Why not just remove the element when scripting is enabled?

Why not just remove the element when scripting is enabled?
erictapen (Migrated from github.com) reviewed 2024-12-06 11:34:22 +00:00
src/website/webview/templates/components/suggestion.html
erictapen (Migrated from github.com) commented 2024-12-06 11:34:22 +00:00
Copy link

I spent some time trying to do that in htmx, but didn't figure out how. Would be cool if htmx had some init event that can be used for hx-on.

For now I included one line of JS code in the base.html file.

I spent some time trying to do that in htmx, but didn't figure out how. Would be cool if htmx had some init event that can be used for `hx-on`. For now I included one line of JS code in the `base.html` file.
fricklerhandwerk (Migrated from github.com) approved these changes 2024-12-06 13:43:12 +00:00
fricklerhandwerk (Migrated from github.com) left a comment
Copy link

Works, but given the number of conditionals it's time for factoring out the dynamics, as discussed, before moving on with new features in that code.

Works, but given the number of conditionals it's time for factoring out the dynamics, as discussed, before moving on with new features in that code.
fricklerhandwerk (Migrated from github.com) reviewed 2024-12-06 13:43:58 +00:00
src/website/webview/templates/components/suggestion.html
fricklerhandwerk (Migrated from github.com) commented 2024-12-06 13:43:58 +00:00
Copy link

I also had a look into that, but the classic seems to be the only reasonable thing.

I also had a look into that, but the classic seems to be the only reasonable thing.
Sign in to join this conversation.
Reviewers
No reviewers
fricklerhandwerk
Labels
Clear labels   
automation

   
backend

something the web server needs to provide the frontend with

  
bug

Something isn't working

  
contributor experience

   
data

something about quality or quantity of ingested data

  
deployment

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
nice to have

Nice to have, but not necessary for the time being

  
notifications

   
package maintainer

user story for package maintainers

  
performance

   
skin

Anything related to the visual presentation

  
tech debt

Activities that reduce tech debt

  
user story

description or implementation of a workflow

No labels
automation
backend
bug
contributor experience
data
deployment
documentation
duplicate
good first issue
help wanted
nice to have
notifications
package maintainer
performance
skin
tech debt
user story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-community/nix-security-tracker#423
No description provided.
Delete branch "instant-package-removal"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?