Removed suggestions show up in selected view #396

New issue

Closed

opened 2024-11-29 13:42:16 +00:00 by fricklerhandwerk · 3 comments

fricklerhandwerk commented

2024-11-29 13:42:16 +00:00

(Migrated from github.com)

In the triage view, after removing derivations from a suggestion and clicking "select" or "dismiss", the derivations are shown again on the suggestion in the respective other view.

Implementation notes:

This is an issue the cache not getting updated
@RaitoBezarius proposed to not change the suggestion at all, but merely store markers for which derivations where removed and compute the desired result in the view.

In the triage view, after removing derivations from a suggestion and clicking "select" or "dismiss", the derivations are shown again on the suggestion in the respective other view. Implementation notes: - This is an issue the cache not getting updated - @RaitoBezarius proposed to not change the suggestion at all, but merely store markers for which derivations where removed and compute the desired result in the view.

erictapen commented

2024-11-29 13:44:34 +00:00

(Migrated from github.com)

One attempt to fix this, was https://github.com/Nix-Security-WG/nix-security-tracker/pull/384, but it will probably be closed.

RaitoBezarius commented

2024-11-29 14:26:11 +00:00

(Migrated from github.com)

@RaitoBezarius proposed to not change the suggestion at all, but merely store markers for which derivations where removed and compute the desired result in the view.

Correction: apply the change to the suggestion and the cached variant.

> @RaitoBezarius proposed to not change the suggestion at all, but merely store markers for which derivations where removed and compute the desired result in the view. Correction: apply the change to the suggestion _and_ the cached variant.

👍 1

fricklerhandwerk commented

2024-12-05 10:44:47 +00:00

(Migrated from github.com)

Closed by https://github.com/Nix-Security-WG/nix-security-tracker/pull/384