feat: the delta CVE ingester can replace the bulk CVE ingester #388

Merged

RaitoBezarius merged 2 commits from faster-initialization into main

2024-11-30 15:05:15 +00:00

RaitoBezarius commented

2024-11-28 15:33:23 +00:00

(Migrated from github.com)

It supports parallelism but make_cve does not.

This will result in many deadlocks and issues during the transaction if
it's run with more than one process.

Signed-off-by: Raito Bezarius masterancpp@gmail.com

It supports parallelism but `make_cve` does not. This will result in many deadlocks and issues during the transaction if it's run with more than one process. Signed-off-by: Raito Bezarius <masterancpp@gmail.com>

RaitoBezarius commented

2024-11-28 15:33:50 +00:00

(Migrated from github.com)

Fixes #359.

fricklerhandwerk (Migrated from github.com) approved these changes

2024-11-28 15:53:31 +00:00

fricklerhandwerk (Migrated from github.com) left a comment

A few maintenance-oriented questions, LGTM morally otherwise.

nix/web-security-tracker.nix

fricklerhandwerk (Migrated from github.com) commented

2024-11-28 15:52:08 +00:00

      defaultText = "the application default: January 1st of the prior year";

Regarding "why", maybe the option's description the right place to put it because ideally this is the only place where anyone would ever have to manually interact with it.

```suggestion defaultText = "the application default: January 1st of the prior year"; ``` Regarding "why", maybe the option's `description` the right place to put it because ideally this is the only place where anyone would ever have to manually interact with it.

src/website/shared/management/commands/ingest_delta_cve.py

fricklerhandwerk (Migrated from github.com) commented

2024-11-28 15:49:48 +00:00

That's evident from the code, but not why, please reword the comment to tell that.

That's evident from the code, but not *why*, please reword the comment to tell that.

fricklerhandwerk (Migrated from github.com) commented

2024-11-28 15:50:43 +00:00

Why do we have a default here, especially if it's unsafe with >1 as is? The CLI already sets a default