lix-community/nix-security-tracker
0
0
Fork 0
Code Issues 94 Pull requests 9 Projects Releases Packages Wiki Activity

feat: cache the suggestions in a JSON payload #378

Merged
RaitoBezarius merged 6 commits from cache-suggestions into main 2024-11-21 08:33:04 +00:00
Conversation 3 Commits 6 Files changed 15 +303 -48
RaitoBezarius commented 2024-11-20 15:20:37 +00:00 (Migrated from github.com)
Copy link

which can be pulled back, paginated, etc.

This will run automatically upon every new insertion of pending proposal.

which can be pulled back, paginated, etc. This will run automatically upon every new insertion of pending proposal.
fricklerhandwerk (Migrated from github.com) reviewed 2024-11-20 21:17:20 +00:00
src/website/shared/listeners/cache_suggestions.py
@ -0,0 +53,4 @@
if not relevant_piece:
# No package name.
return
relevant_piece = relevant_piece[0]
fricklerhandwerk (Migrated from github.com) commented 2024-11-20 21:17:20 +00:00
Copy link

@erictapen I guess we're already using more than just the first random package name, at least in https://github.com/Nix-Security-WG/nix-security-tracker/pull/365? I fear that one will need rebasing

@erictapen I guess we're already using more than just the first random package name, at least in https://github.com/Nix-Security-WG/nix-security-tracker/pull/365? I fear that one will need rebasing
fricklerhandwerk (Migrated from github.com) reviewed 2024-11-20 21:17:40 +00:00
src/website/shared/listeners/cache_suggestions.py
@ -0,0 +56,4 @@
relevant_piece = relevant_piece[0]
# This is not a suggestion we want to show.
if suggestion.derivations.count() > 1_000:
fricklerhandwerk (Migrated from github.com) commented 2024-11-20 21:17:39 +00:00
Copy link

More like

    if suggestion.derivations.count() > 100:
More like ```suggestion if suggestion.derivations.count() > 100: ```
fricklerhandwerk (Migrated from github.com) approved these changes 2024-11-21 08:32:12 +00:00
fricklerhandwerk (Migrated from github.com) left a comment
Copy link

Nice, this does the trick

Nice, this does the trick
Sign in to join this conversation.
Reviewers
No reviewers
fricklerhandwerk
Labels
Clear labels   
automation

   
backend

something the web server needs to provide the frontend with

  
bug

Something isn't working

  
contributor experience

   
data

something about quality or quantity of ingested data

  
deployment

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
nice to have

Nice to have, but not necessary for the time being

  
notifications

   
package maintainer

user story for package maintainers

  
performance

   
skin

Anything related to the visual presentation

  
tech debt

Activities that reduce tech debt

  
user story

description or implementation of a workflow

No labels
automation
backend
bug
contributor experience
data
deployment
documentation
duplicate
good first issue
help wanted
nice to have
notifications
package maintainer
performance
skin
tech debt
user story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-community/nix-security-tracker#378
No description provided.
Delete branch "cache-suggestions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?