lix-community/nix-security-tracker
0
0
Fork 0
Code Issues 94 Pull requests 9 Projects Releases Packages Wiki Activity

feat: Suggestion view pt.2 #293

Merged
erictapen merged 2 commits from suggestion-view into main 2024-10-31 11:58:56 +00:00
Conversation 11 Commits 2 Files changed 4 +318 -31
erictapen commented 2024-10-28 11:00:24 +00:00 (Migrated from github.com)
Copy link

Closes https://github.com/Nix-Security-WG/nix-security-tracker/issues/203
Closes https://github.com/Nix-Security-WG/nix-security-tracker/issues/210

Some better rendering for package versions.

Closes https://github.com/Nix-Security-WG/nix-security-tracker/issues/203 Closes https://github.com/Nix-Security-WG/nix-security-tracker/issues/210 Some better rendering for package versions.
RaitoBezarius (Migrated from github.com) reviewed 2024-10-28 11:10:24 +00:00
src/website/webview/views.py
RaitoBezarius (Migrated from github.com) commented 2024-10-28 11:10:24 +00:00
Copy link

It's a wrong assumption, there are multiple containers, but we shall only select the most relevant one

It's a wrong assumption, there are multiple containers, but we shall only select the most relevant one
RaitoBezarius (Migrated from github.com) reviewed 2024-10-28 11:11:03 +00:00
src/website/webview/views.py
RaitoBezarius (Migrated from github.com) commented 2024-10-28 11:11:03 +00:00
Copy link

Can the channel analyzing logic be moved in its own functions and possibly a utility file for channel analysis?

Can the channel analyzing logic be moved in its own functions and possibly a utility file for channel analysis?
erictapen (Migrated from github.com) reviewed 2024-10-28 11:15:52 +00:00
src/website/webview/views.py
erictapen (Migrated from github.com) commented 2024-10-28 11:15:52 +00:00
Copy link

Definetly, this entire logic is way too noisy for the view.

Definetly, this entire logic is way too noisy for the view.
erictapen (Migrated from github.com) reviewed 2024-10-28 11:16:14 +00:00
src/website/webview/views.py
erictapen (Migrated from github.com) commented 2024-10-28 11:16:14 +00:00
Copy link

Any idea how to figure out the most relevant one?

Any idea how to figure out the most relevant one?
erictapen (Migrated from github.com) reviewed 2024-10-28 11:19:46 +00:00
src/website/webview/views.py
erictapen (Migrated from github.com) commented 2024-10-28 11:19:46 +00:00
Copy link

https://github.com/Nix-Security-WG/nix-security-tracker/issues/294

https://github.com/Nix-Security-WG/nix-security-tracker/issues/294
erictapen (Migrated from github.com) reviewed 2024-10-28 11:24:29 +00:00
src/website/webview/views.py
erictapen (Migrated from github.com) commented 2024-10-28 11:24:29 +00:00
Copy link

https://github.com/Nix-Security-WG/nix-security-tracker/issues/295

https://github.com/Nix-Security-WG/nix-security-tracker/issues/295
RaitoBezarius (Migrated from github.com) reviewed 2024-10-28 11:35:05 +00:00
src/website/webview/views.py
RaitoBezarius (Migrated from github.com) commented 2024-10-28 11:35:05 +00:00
Copy link

Hmm… I need to think, but basically you need to select the first container containing a package name or containing a CVSS vector string, this sort of stuff.

Maybe, the backend should do more preprocessing to make this palatable.

Hmm… I need to think, but basically you need to select the first container containing a package name or containing a CVSS vector string, this sort of stuff. Maybe, the backend should do more preprocessing to make this palatable.
erictapen (Migrated from github.com) reviewed 2024-10-30 12:12:56 +00:00
src/website/webview/views.py
erictapen (Migrated from github.com) commented 2024-10-30 12:12:56 +00:00
Copy link

This is probably wrong but I ended up moving this into the models for now? I thought it might make sense, as the function operates on the types in the nix_evaluation model.

This is probably wrong but I ended up moving this into the models for now? I thought it might make sense, as the function operates on the types in the `nix_evaluation` model.
erictapen (Migrated from github.com) reviewed 2024-10-31 09:48:49 +00:00
src/website/webview/views.py
erictapen (Migrated from github.com) commented 2024-10-31 09:48:49 +00:00
Copy link

This might be actually solved by your intermediate representation of merged CVEs, right?

This might be actually solved by your intermediate representation of merged CVEs, right?
RaitoBezarius (Migrated from github.com) reviewed 2024-10-31 09:57:31 +00:00
src/website/webview/views.py
RaitoBezarius (Migrated from github.com) commented 2024-10-31 09:57:31 +00:00
Copy link

correct!

correct!
fricklerhandwerk (Migrated from github.com) approved these changes 2024-10-31 11:58:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fricklerhandwerk
Labels
Clear labels   
automation

   
backend

something the web server needs to provide the frontend with

  
bug

Something isn't working

  
contributor experience

   
data

something about quality or quantity of ingested data

  
deployment

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
nice to have

Nice to have, but not necessary for the time being

  
notifications

   
package maintainer

user story for package maintainers

  
performance

   
skin

Anything related to the visual presentation

  
tech debt

Activities that reduce tech debt

  
user story

description or implementation of a workflow

No labels
automation
backend
bug
contributor experience
data
deployment
documentation
duplicate
good first issue
help wanted
nice to have
notifications
package maintainer
performance
skin
tech debt
user story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-community/nix-security-tracker#293
No description provided.
Delete branch "suggestion-view"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?