lix-community/nix-security-tracker
0
0
Fork 0
Code Issues 94 Pull requests 9 Projects Releases Packages Wiki Activity

Refactor receiver for allauth.signals.user_sign_up #166

New issue
Open
opened 2024-07-18 16:54:03 +00:00 by alejandrosame · 0 comments
alejandrosame commented 2024-07-18 16:54:03 +00:00 (Migrated from github.com)
Copy link

As noted in https://github.com/Nix-Security-WG/nix-security-tracker/pull/165#discussion_r1682547683, the following refactor will improve the readability of the Github sync code and its test suite:

  • Move set_groups_for_new_user inside the GithubState class, and connect it to the user_sign_up signal within the constructor.
  • In the tests, trigger the signal and use @patch to mock the GitHub requests.
As noted in https://github.com/Nix-Security-WG/nix-security-tracker/pull/165#discussion_r1682547683, the following refactor will improve the readability of the Github sync code and its test suite: - Move `set_groups_for_new_user` inside the `GithubState` class, and connect it to the `user_sign_up` signal within the constructor. - In the tests, trigger the signal and use `@patch` to mock the GitHub requests.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
npins-auto-update
No results found.
Labels
Clear labels   
automation

   
backend

something the web server needs to provide the frontend with

  
bug

Something isn't working

  
contributor experience

   
data

something about quality or quantity of ingested data

  
deployment

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
nice to have

Nice to have, but not necessary for the time being

  
notifications

   
package maintainer

user story for package maintainers

  
performance

   
skin

Anything related to the visual presentation

  
tech debt

Activities that reduce tech debt

  
user story

description or implementation of a workflow

No labels
automation
backend
bug
contributor experience
data
deployment
documentation
duplicate
good first issue
help wanted
nice to have
notifications
package maintainer
performance
skin
tech debt
user story
Milestone
Clear milestone
No items
No milestone
Nice to have
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-community/nix-security-tracker#166
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?