lehmanator/lix
0
0
Fork 0
forked from lix-project/lix
Code Pull requests Activity

libutil: make RunningProgram::wait more resilient

Browse source 
this will usually be used either directly (which is always fine) or in
Finally blocks (where it must never throw execptions). make sure that,
exceptions being handled or not, the calling wait() in Finally doesn't
cause crashes due to the Finally no-nested-exceptions-thrown assertion

Change-Id: Ib83a5d9483b1fe83b9a957dcefeefce5d088f06d
This commit is contained in:
eldritch horrors 2024-07-19 17:54:30 +02:00
parent c907d805bf
commit 868eb5ecde
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/libutil/processes.cc
View file

@ -280,9 +280,14 @@ RunningProgram::~RunningProgram()
void RunningProgram::wait() void RunningProgram::wait()
{ {
int status = pid.wait(); if (std::uncaught_exceptions() == 0) {
if (status) int status = pid.wait();
throw ExecError(status, "program '%1%' %2%", program, statusToString(status)); if (status)
throw ExecError(status, "program '%1%' %2%", program, statusToString(status));
} else {
pid.kill();
debug("killed subprocess %1% during exception handling", program);
}
} }
RunningProgram runProgram2(const RunOptions & options) RunningProgram runProgram2(const RunOptions & options)