lehmanator/lix
0
0
Fork 0
forked from lix-project/lix
Code Pull requests Activity

Fix segfault on Darwin

Browse source 
Ever since SQLite in Nixpkgs was updated to 3.8.0.2, Nix has randomly
segfaulted on Darwin:

  http://hydra.nixos.org/build/6175515
  http://hydra.nixos.org/build/6611038

It turns out that this is because the binary cache substituter somehow
ends up loading two versions of SQLite: the one in Nixpkgs and the
other from /usr/lib/libsqlite3.dylib.  It's not exactly clear why the
latter is loaded, but it appears to be because WWW::Curl indirectly loads
/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation,
which in turn seems to load /usr/lib/libsqlite3.dylib.  This leads to
a segfault when Perl exits:

  #0  0x00000001010375f4 in sqlite3_finalize ()
  #1  0x000000010125806e in sqlite_st_destroy ()
  #2  0x000000010124bc30 in XS_DBD__SQLite__st_DESTROY ()
  #3  0x00000001001c8155 in XS_DBI_dispatch ()
  ...
  #14 0x0000000100023224 in perl_destruct ()
  #15 0x0000000100000d6a in main ()
  ...

The workaround is to explicitly load DBD::SQLite before WWW::Curl.
This commit is contained in:
Eelco Dolstra 2013-10-24 19:10:38 +02:00
parent 5bc41d78ff
commit 2d9bb56e55
2 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
perl/lib/Nix/Manifest.pm
View file

@ -2,6 +2,7 @@ package Nix::Manifest;
use strict; use strict;
use DBI; use DBI;
use DBD::SQLite;
use Cwd; use Cwd;
use File::stat; use File::stat;
use File::Path; use File::Path;

1
scripts/download-from-binary-cache.pl.in
View file

@ -1,6 +1,7 @@
#! @perl@ -w @perlFlags@ #! @perl@ -w @perlFlags@
use DBI; use DBI;
use DBD::SQLite;
use File::Basename; use File::Basename;
use IO::Select; use IO::Select;
use Nix::Config; use Nix::Config;