From e5951a6b2ffcb1b06c63bffb2549f00b12012c6d Mon Sep 17 00:00:00 2001 From: Maximilian Bosch Date: Mon, 3 May 2021 01:12:23 +0200 Subject: [PATCH] Bump version number for `DerivedPath` changes I guess I misunderstood John's initial explanation about why wildcards for outputs are sent to older stores[1]. My `nix-daemon` from 2021-03-26 also has version 1.29, but misses the wildcard[2]. So bumping seems to be the right call. [1] https://github.com/NixOS/nix/pull/4759#issuecomment-830812464 [2] 255d145ba7ac907d1cba8d088da556b591627756 --- src/libstore/daemon.cc | 2 +- src/libstore/remote-store.cc | 2 +- src/libstore/worker-protocol.hh | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libstore/daemon.cc b/src/libstore/daemon.cc index 0be9d2c54..72b3e3e13 100644 --- a/src/libstore/daemon.cc +++ b/src/libstore/daemon.cc @@ -263,7 +263,7 @@ static void writeValidPathInfo( static std::vector readDerivedPaths(Store & store, unsigned int clientVersion, Source & from) { std::vector reqs; - if (GET_PROTOCOL_MINOR(clientVersion) >= 29) { + if (GET_PROTOCOL_MINOR(clientVersion) >= 30) { reqs = worker_proto::read(store, from, Phantom> {}); } else { for (auto & s : readStrings(from)) diff --git a/src/libstore/remote-store.cc b/src/libstore/remote-store.cc index 761b4a087..d9b6e9488 100644 --- a/src/libstore/remote-store.cc +++ b/src/libstore/remote-store.cc @@ -672,7 +672,7 @@ std::optional RemoteStore::queryRealisation(const DrvOutput & static void writeDerivedPaths(RemoteStore & store, ConnectionHandle & conn, const std::vector & reqs) { - if (GET_PROTOCOL_MINOR(conn->daemonVersion) >= 29) { + if (GET_PROTOCOL_MINOR(conn->daemonVersion) >= 30) { worker_proto::write(store, conn->to, reqs); } else { Strings ss; diff --git a/src/libstore/worker-protocol.hh b/src/libstore/worker-protocol.hh index 001ed25e3..fdd692cf0 100644 --- a/src/libstore/worker-protocol.hh +++ b/src/libstore/worker-protocol.hh @@ -9,7 +9,7 @@ namespace nix { #define WORKER_MAGIC_1 0x6e697863 #define WORKER_MAGIC_2 0x6478696f -#define PROTOCOL_VERSION (1 << 8 | 29) +#define PROTOCOL_VERSION (1 << 8 | 30) #define GET_PROTOCOL_MAJOR(x) ((x) & 0xff00) #define GET_PROTOCOL_MINOR(x) ((x) & 0x00ff)