From 0413aeb35d6ee869a98b6565781c1cf47dc80080 Mon Sep 17 00:00:00 2001 From: Maximilian Bosch Date: Tue, 31 Oct 2017 11:57:53 +0100 Subject: [PATCH] search.cc: sort attribute names with `std::map` --- src/nix/search.cc | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/nix/search.cc b/src/nix/search.cc index 87cdb2d7e..0fbd3b6c0 100644 --- a/src/nix/search.cc +++ b/src/nix/search.cc @@ -82,8 +82,6 @@ struct CmdSearch : SourceExprCommand, MixJSON auto state = getEvalState(); - bool first = true; - auto jsonOut = json ? std::make_unique(std::cout) : nullptr; auto sToplevel = state->symbols.create("_toplevel"); @@ -91,6 +89,8 @@ struct CmdSearch : SourceExprCommand, MixJSON bool fromCache = false; + std::map results; + std::function doExpr; doExpr = [&](Value * v, std::string attrPath, bool toplevel, JSONObject * cache) { @@ -138,10 +138,7 @@ struct CmdSearch : SourceExprCommand, MixJSON jsonElem.attr("description", description); } else { - if (!first) std::cout << "\n"; - first = false; - - std::cout << fmt( + results[attrPath] = fmt( "Attribute name: %s\n" "Package name: %s\n" "Version: %s\n" @@ -240,6 +237,9 @@ struct CmdSearch : SourceExprCommand, MixJSON if (rename(tmpFile.c_str(), jsonCacheFileName.c_str()) == -1) throw SysError("cannot rename '%s' to '%s'", tmpFile, jsonCacheFileName); } + + for (auto el : results) std::cout << el.second << "\n"; + } };