forked from lix-project/lix
3d065192c0
As I complained in
https://github.com/NixOS/nix/pull/6784#issuecomment-1421777030 (a
comment on the wrong PR, sorry again!), #6693 introduced a second
completions mechanism to fix a bug. Having two completion mechanisms
isn't so nice.
As @thufschmitt also pointed out, it was a bummer to go from `FlakeRef`
to `std::string` when collecting flake refs. Now it is `FlakeRefs`
again.
The underlying issue that sought to work around was that completion of
arguments not at the end can still benefit from the information from
latter arguments.
To fix this better, we rip out that change and simply defer all
completion processing until after all the (regular, already-complete)
arguments have been passed.
In addition, I noticed the original completion logic used some global
variables. I do not like global variables, because even if they save
lines of code, they also obfuscate the architecture of the code.
I got rid of them moved them to a new `RootArgs` class, which now has
`parseCmdline` instead of `Args`. The idea is that we have many argument
parsers from subcommands and what-not, but only one root args that owns
the other per actual parsing invocation. The state that was global is
now part of the root args instead.
This did, admittedly, add a bunch of new code. And I do feel bad about
that. So I went and added a lot of API docs to try to at least make the
current state of things clear to the next person.
--
This is needed for RFC 134 (tracking issue #7868). It was very hard to
modularize `Installable` parsing when there were two completion
arguments. I wouldn't go as far as to say it is *easy* now, but at least
it is less hard (and the completions test finally passed).
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
Change-Id:
|
||
|---|---|---|
| .. | ||
| built-path.cc | ||
| built-path.hh | ||
| command-installable-value.cc | ||
| command-installable-value.hh | ||
| command.cc | ||
| command.hh | ||
| common-eval-args.cc | ||
| common-eval-args.hh | ||
| editor-for.cc | ||
| editor-for.hh | ||
| installable-attr-path.cc | ||
| installable-attr-path.hh | ||
| installable-derived-path.cc | ||
| installable-derived-path.hh | ||
| installable-flake.cc | ||
| installable-flake.hh | ||
| installable-value.cc | ||
| installable-value.hh | ||
| installables.cc | ||
| installables.hh | ||
| legacy.cc | ||
| legacy.hh | ||
| local.mk | ||
| markdown.cc | ||
| markdown.hh | ||
| meson.build | ||
| nix-cmd.pc.in | ||
| repl-interacter.cc | ||
| repl-interacter.hh | ||
| repl.cc | ||
| repl.hh | ||