From f3c85f9eb395b13790d1fced05665125e2ec81ca Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Fri, 11 May 2018 11:39:25 +0200 Subject: [PATCH] Revert "Throw a specific error for incomplete parse errors." This reverts commit 6498adb002bcf7e715afe46c23b8635d4592c156. We don't actually use IncompleteParseError in 'nix repl'. --- src/libexpr/lexer.l | 2 -- src/libexpr/nixexpr.hh | 1 - src/libexpr/parser.y | 9 +-------- 3 files changed, 1 insertion(+), 11 deletions(-) diff --git a/src/libexpr/lexer.l b/src/libexpr/lexer.l index 1e9c29afa..8855d794e 100644 --- a/src/libexpr/lexer.l +++ b/src/libexpr/lexer.l @@ -213,7 +213,5 @@ or { return OR_KW; } } -<> { data->atEnd = true; return 0; } - %% diff --git a/src/libexpr/nixexpr.hh b/src/libexpr/nixexpr.hh index b486595f0..665a42987 100644 --- a/src/libexpr/nixexpr.hh +++ b/src/libexpr/nixexpr.hh @@ -11,7 +11,6 @@ namespace nix { MakeError(EvalError, Error) MakeError(ParseError, Error) -MakeError(IncompleteParseError, ParseError) MakeError(AssertionError, EvalError) MakeError(ThrownError, AssertionError) MakeError(Abort, EvalError) diff --git a/src/libexpr/parser.y b/src/libexpr/parser.y index e3f452184..eee48887d 100644 --- a/src/libexpr/parser.y +++ b/src/libexpr/parser.y @@ -31,12 +31,10 @@ namespace nix { Path basePath; Symbol path; string error; - bool atEnd; Symbol sLetBody; ParseData(EvalState & state) : state(state) , symbols(state.symbols) - , atEnd(false) , sLetBody(symbols.create("")) { }; }; @@ -541,12 +539,7 @@ Expr * EvalState::parse(const char * text, int res = yyparse(scanner, &data); yylex_destroy(scanner); - if (res) { - if (data.atEnd) - throw IncompleteParseError(data.error); - else - throw ParseError(data.error); - } + if (res) throw ParseError(data.error); data.result->bindVars(staticEnv);