From 3cac8734acb098488bd232bcee92099410d4d167 Mon Sep 17 00:00:00 2001 From: Will Dietz Date: Sun, 25 Feb 2018 16:32:36 -0600 Subject: [PATCH] nix search: fix bug where we wrote to cache when shouldn't, breaking This is exposed by the tests added previously, and resolves the error reported in #1892: "expected JSON value". --- src/nix/search.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nix/search.cc b/src/nix/search.cc index 87cdb2d7e..1adde28cb 100644 --- a/src/nix/search.cc +++ b/src/nix/search.cc @@ -237,7 +237,7 @@ struct CmdSearch : SourceExprCommand, MixJSON throw Error("error writing to %s", tmpFile); } - if (rename(tmpFile.c_str(), jsonCacheFileName.c_str()) == -1) + if (writeCache && rename(tmpFile.c_str(), jsonCacheFileName.c_str()) == -1) throw SysError("cannot rename '%s' to '%s'", tmpFile, jsonCacheFileName); } }