From 38e4e6963305ce6831971071455379b6e5b8619f Mon Sep 17 00:00:00 2001 From: Jade Lovelace Date: Tue, 11 Jun 2024 20:41:32 -0700 Subject: [PATCH] .github: clean up stale things and wrong references We do not need a stale bot. We do not need dependabot. Fixes: https://git.lix.systems/lix-project/lix/issues/391 Change-Id: I983fae4dc4cd9022b12f70e330b5c984c5fc1b9d --- .github/CODEOWNERS | 18 ---------- .github/ISSUE_TEMPLATE/installer.md | 2 +- .../ISSUE_TEMPLATE/missing_documentation.md | 11 +++--- .github/STALE-BOT.md | 35 ------------------- .github/dependabot.yml | 6 ---- .github/labeler.yml | 23 ------------ .github/stale.yml | 9 ----- 7 files changed, 7 insertions(+), 97 deletions(-) delete mode 100644 .github/CODEOWNERS delete mode 100644 .github/STALE-BOT.md delete mode 100644 .github/dependabot.yml delete mode 100644 .github/labeler.yml delete mode 100644 .github/stale.yml diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS deleted file mode 100644 index ab5908649..000000000 --- a/.github/CODEOWNERS +++ /dev/null @@ -1,18 +0,0 @@ -# Pull requests concerning the listed files will automatically invite the respective maintainers as reviewers. -# This file is not used for denoting any kind of ownership, but is merely a tool for handling notifications. -# -# Merge permissions are required for maintaining an entry in this file. -# For documentation on this mechanism, see https://help.github.com/articles/about-codeowners/ - -# Default reviewers if nothing else matches -* @edolstra - -# This file -.github/CODEOWNERS @edolstra - -# Public documentation -/doc @fricklerhandwerk -*.md @fricklerhandwerk - -# Libstore layer -/src/libstore @thufschmitt diff --git a/.github/ISSUE_TEMPLATE/installer.md b/.github/ISSUE_TEMPLATE/installer.md index 05a2e1474..9e4189fa3 100644 --- a/.github/ISSUE_TEMPLATE/installer.md +++ b/.github/ISSUE_TEMPLATE/installer.md @@ -9,7 +9,7 @@ assignees: '' ## Platform - + - [ ] Linux: - [ ] macOS diff --git a/.github/ISSUE_TEMPLATE/missing_documentation.md b/.github/ISSUE_TEMPLATE/missing_documentation.md index 250373feb..fa3a5137a 100644 --- a/.github/ISSUE_TEMPLATE/missing_documentation.md +++ b/.github/ISSUE_TEMPLATE/missing_documentation.md @@ -19,9 +19,10 @@ assignees: '' -- [ ] checked [latest Nix manual] \([source]) -- [ ] checked [open documentation issues and pull requests] for possible duplicates +- [ ] checked [latest Lix manual] \([source]\) +- [ ] checked [documentation issues] and [recent documentation changes] for possible duplicates -[latest Nix manual]: https://nixos.org/manual/nix/unstable/ -[source]: https://github.com/NixOS/nix/tree/master/doc/manual/src -[open documentation issues and pull requests]: https://github.com/NixOS/nix/labels/documentation +[latest Nix manual]: https://docs.lix.systems/manual/lix/nightly +[source]: https://git.lix.systems/lix-project/lix/src/main/doc/manual/src +[documentation issues]: https://git.lix.systems/lix-project/lix/issues?labels=151&state=all +[recent documentation changes]: https://gerrit.lix.systems/q/p:lix+path:%22%5Edoc/manual/.*%22 diff --git a/.github/STALE-BOT.md b/.github/STALE-BOT.md deleted file mode 100644 index 383717bfc..000000000 --- a/.github/STALE-BOT.md +++ /dev/null @@ -1,35 +0,0 @@ -# Stale bot information - -- Thanks for your contribution! -- To remove the stale label, just leave a new comment. -- _How to find the right people to ping?_ → [`git blame`](https://git-scm.com/docs/git-blame) to the rescue! (or GitHub's history and blame buttons.) -- You can always ask for help on [our Discourse Forum](https://discourse.nixos.org/) or on [Matrix - #nix:nixos.org](https://matrix.to/#/#nix:nixos.org). - -## Suggestions for PRs - -1. GitHub sometimes doesn't notify people who commented / reviewed a PR previously, when you (force) push commits. If you have addressed the reviews you can [officially ask for a review](https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/requesting-a-pull-request-review) from those who commented to you or anyone else. -2. If it is unfinished but you plan to finish it, please mark it as a draft. -3. If you don't expect to work on it any time soon, closing it with a short comment may encourage someone else to pick up your work. -4. To get things rolling again, rebase the PR against the target branch and address valid comments. -5. If you need a review to move forward, ask in [the Discourse thread for PRs that need help](https://discourse.nixos.org/t/prs-in-distress/3604). -6. If all you need is a merge, check the git history to find and [request reviews](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/requesting-a-pull-request-review) from people who usually merge related contributions. - -## Suggestions for issues - -1. If it is resolved (either for you personally, or in general), please consider closing it. -2. If this might still be an issue, but you are not interested in promoting its resolution, please consider closing it while encouraging others to take over and reopen an issue if they care enough. -3. If you still have interest in resolving it, try to ping somebody who you believe might have an interest in the topic. Consider discussing the problem in [our Discourse Forum](https://discourse.nixos.org/). -4. As with all open source projects, your best option is to submit a Pull Request that addresses this issue. We :heart: this attitude! - -**Memorandum on closing issues** - -Don't be afraid to close an issue that holds valuable information. Closed issues stay in the system for people to search, read, cross-reference, or even reopen--nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort. - -## Useful GitHub search queries - -- [Open PRs with any stale-bot interaction](https://github.com/NixOS/nix/pulls?q=is%3Apr+is%3Aopen+commenter%3Aapp%2Fstale+) -- [Open PRs with any stale-bot interaction and `stale`](https://github.com/NixOS/nix/pulls?q=is%3Apr+is%3Aopen+commenter%3Aapp%2Fstale+label%3A%22stale%22) -- [Open PRs with any stale-bot interaction and NOT `stale`](https://github.com/NixOS/nix/pulls?q=is%3Apr+is%3Aopen+commenter%3Aapp%2Fstale+-label%3A%22stale%22+) -- [Open Issues with any stale-bot interaction](https://github.com/NixOS/nix/issues?q=is%3Aissue+is%3Aopen+commenter%3Aapp%2Fstale+) -- [Open Issues with any stale-bot interaction and `stale`](https://github.com/NixOS/nix/issues?q=is%3Aissue+is%3Aopen+commenter%3Aapp%2Fstale+label%3A%22stale%22+) -- [Open Issues with any stale-bot interaction and NOT `stale`](https://github.com/NixOS/nix/issues?q=is%3Aissue+is%3Aopen+commenter%3Aapp%2Fstale+-label%3A%22stale%22+) diff --git a/.github/dependabot.yml b/.github/dependabot.yml deleted file mode 100644 index 5ace4600a..000000000 --- a/.github/dependabot.yml +++ /dev/null @@ -1,6 +0,0 @@ -version: 2 -updates: - - package-ecosystem: "github-actions" - directory: "/" - schedule: - interval: "weekly" diff --git a/.github/labeler.yml b/.github/labeler.yml deleted file mode 100644 index 7544f07a6..000000000 --- a/.github/labeler.yml +++ /dev/null @@ -1,23 +0,0 @@ -"documentation": - - doc/manual/* - - src/nix/**/*.md - -"store": - - src/libstore/store-api.* - - src/libstore/*-store.* - -"fetching": - - src/libfetchers/**/* - -"repl": - - src/libcmd/repl.* - - src/nix/repl.* - -"new-cli": - - src/nix/**/* - -"with-tests": - # Unit tests - - src/*/tests/**/* - # Functional and integration tests - - tests/functional/**/* diff --git a/.github/stale.yml b/.github/stale.yml deleted file mode 100644 index ee831135a..000000000 --- a/.github/stale.yml +++ /dev/null @@ -1,9 +0,0 @@ -# Configuration for probot-stale - https://github.com/probot/stale -daysUntilStale: 180 -daysUntilClose: false -exemptLabels: - - "critical" - - "never-stale" -staleLabel: "stale" -markComment: false -closeComment: false