From e1cf40fa9537162efe0dc19dcea9ae7d043fde66 Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Wed, 19 Feb 2014 16:34:24 +0100 Subject: [PATCH] nix-instantiate: Rename --eval-only to --eval, --parse-only to --parse --- doc/manual/nix-instantiate.xml | 30 +++++++++++++------------- src/nix-instantiate/nix-instantiate.cc | 4 ++-- tests/lang.sh | 10 ++++----- tests/misc.sh | 2 +- 4 files changed, 23 insertions(+), 23 deletions(-) diff --git a/doc/manual/nix-instantiate.xml b/doc/manual/nix-instantiate.xml index a780302e1..b388560a1 100644 --- a/doc/manual/nix-instantiate.xml +++ b/doc/manual/nix-instantiate.xml @@ -19,9 +19,9 @@ nix-instantiate - + - + @@ -84,7 +84,7 @@ input. - + Just parse the input files, and print their abstract syntax trees on standard output in ATerm @@ -92,7 +92,7 @@ input. - + Just parse and evaluate the input files, and print the resulting values on standard output. No instantiation of @@ -115,8 +115,8 @@ input. - When used with and - , print the resulting expression as an + When used with and + , print the resulting expression as an XML representation of the abstract syntax tree rather than as an ATerm. The schema is the same as that used by the toXML @@ -126,7 +126,7 @@ input. - When used with , + When used with , recursively evaluate list elements and attributes. Normally, such sub-expressions are left unevaluated (since the Nix expression language is lazy). @@ -140,9 +140,9 @@ input. - When used with , - perform evaluation in read/write mode so nix language features - that require it will still work (at the cost of needing to do + When used with , perform + evaluation in read/write mode so nix language features that + require it will still work (at the cost of needing to do instantiation of every evaluated derivation). @@ -195,13 +195,13 @@ $ nix-instantiate '<nixpkgs>' -A hello Parsing and evaluating Nix expressions: -$ nix-instantiate --parse-only -E '1 + 2' +$ nix-instantiate --parse -E '1 + 2' 1 + 2 -$ nix-instantiate --eval-only -E '1 + 2' +$ nix-instantiate --eval -E '1 + 2' 3 -$ nix-instantiate --eval-only --xml -E '1 + 2' +$ nix-instantiate --eval --xml -E '1 + 2' @@ -212,7 +212,7 @@ $ nix-instantiate --eval-only --xml -E '1 + 2' The difference between non-strict and strict evaluation: -$ nix-instantiate --eval-only --xml -E 'rec { x = "foo"; y = x; }' +$ nix-instantiate --eval --xml -E 'rec { x = "foo"; y = x; }' ... @@ -226,7 +226,7 @@ Note that y is left unevaluated (the XML representation doesn’t attempt to show non-normal forms). -$ nix-instantiate --eval-only --xml --strict -E 'rec { x = "foo"; y = x; }' +$ nix-instantiate --eval --xml --strict -E 'rec { x = "foo"; y = x; }' ... diff --git a/src/nix-instantiate/nix-instantiate.cc b/src/nix-instantiate/nix-instantiate.cc index 941728698..762b52ae1 100644 --- a/src/nix-instantiate/nix-instantiate.cc +++ b/src/nix-instantiate/nix-instantiate.cc @@ -107,11 +107,11 @@ void run(Strings args) readStdin = true; else if (arg == "--expr" || arg == "-E") fromArgs = true; - else if (arg == "--eval-only") + else if (arg == "--eval" || arg == "--eval-only") evalOnly = true; else if (arg == "--read-write-mode") wantsReadWrite = true; - else if (arg == "--parse-only") + else if (arg == "--parse" || arg == "--parse-only") parseOnly = evalOnly = true; else if (arg == "--find-file") findFile = true; diff --git a/tests/lang.sh b/tests/lang.sh index 0d93b9215..732480652 100644 --- a/tests/lang.sh +++ b/tests/lang.sh @@ -7,7 +7,7 @@ fail=0 for i in lang/parse-fail-*.nix; do echo "parsing $i (should fail)"; i=$(basename $i .nix) - if nix-instantiate --parse-only - < lang/$i.nix; then + if nix-instantiate --parse - < lang/$i.nix; then echo "FAIL: $i shouldn't parse" fail=1 fi @@ -16,7 +16,7 @@ done for i in lang/parse-okay-*.nix; do echo "parsing $i (should succeed)"; i=$(basename $i .nix) - if ! nix-instantiate --parse-only - < lang/$i.nix > lang/$i.out; then + if ! nix-instantiate --parse - < lang/$i.nix > lang/$i.out; then echo "FAIL: $i should parse" fail=1 fi @@ -25,7 +25,7 @@ done for i in lang/eval-fail-*.nix; do echo "evaluating $i (should fail)"; i=$(basename $i .nix) - if nix-instantiate --eval-only lang/$i.nix; then + if nix-instantiate --eval lang/$i.nix; then echo "FAIL: $i shouldn't evaluate" fail=1 fi @@ -40,7 +40,7 @@ for i in lang/eval-okay-*.nix; do if test -e lang/$i.flags; then flags=$(cat lang/$i.flags) fi - if ! NIX_PATH=lang/dir3:lang/dir4_PATH nix-instantiate $flags --eval-only --strict lang/$i.nix > lang/$i.out; then + if ! NIX_PATH=lang/dir3:lang/dir4_PATH nix-instantiate $flags --eval --strict lang/$i.nix > lang/$i.out; then echo "FAIL: $i should evaluate" fail=1 elif ! diff lang/$i.out lang/$i.exp; then @@ -50,7 +50,7 @@ for i in lang/eval-okay-*.nix; do fi if test -e lang/$i.exp.xml; then - if ! nix-instantiate --eval-only --xml --no-location --strict \ + if ! nix-instantiate --eval --xml --no-location --strict \ lang/$i.nix > lang/$i.out.xml; then echo "FAIL: $i should evaluate" fail=1 diff --git a/tests/misc.sh b/tests/misc.sh index 42aa82c8d..1b4d8f2cf 100644 --- a/tests/misc.sh +++ b/tests/misc.sh @@ -5,7 +5,7 @@ source common.sh # Do all commands have help? #nix-env --help | grep -q install #nix-store --help | grep -q realise -#nix-instantiate --help | grep -q eval-only +#nix-instantiate --help | grep -q eval #nix-hash --help | grep -q base32 # Can we ask for the version number?