kloenk/lix
0
0
Fork 0
forked from lix-project/lix
Code Pull requests Activity

Expand tests to reproduce #7655

Browse source 
The original `builtins.getContext` test from
1d757292d0 would have caught this. The
problem is that b30be6b450 adding
`builtins.appendContext` modified that test to make it test too much at
once, rather than adding a separate test.

We now have isolated tests for both functions, and also a property test
showing everything put together (in the form of an eta rule for strings
with context). This is better coverage and properly reproduces the bug.
This commit is contained in:
John Ericson 2023-01-21 23:50:09 -05:00
parent 04de0dd0b4
commit 88d8f6ac48
2 changed files with 21 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tests/lang/eval-okay-context-introspection.exp
View file

@ -1 +1 @@
true [ true true true true true true ]

23
tests/lang/eval-okay-context-introspection.nix
View file

@ -18,7 +18,24 @@ let
}; };
}; };
legit-context = builtins.getContext "${path}${drv.outPath}${drv.foo.outPath}${drv.drvPath}"; combo-path = "${path}${drv.outPath}${drv.foo.outPath}${drv.drvPath}";
legit-context = builtins.getContext combo-path;
constructed-context = builtins.getContext (builtins.appendContext "" desired-context); reconstructed-path = builtins.appendContext
in legit-context == constructed-context (builtins.unsafeDiscardStringContext combo-path)
desired-context;
# Eta rule for strings with context.
etaRule = str:
str == builtins.appendContext
(builtins.unsafeDiscardStringContext str)
(builtins.getContext str);
in [
(legit-context == desired-context)
(reconstructed-path == combo-path)
(etaRule "foo")
(etaRule drv.drvPath)
(etaRule drv.foo.outPath)
(etaRule (builtins.unsafeDiscardOutputDependency drv.drvPath))
]