forked from lix-project/lix
alois31
0dd1d8ca1c
Previously, the progress bar had two subtly different states in which the bar would not actually render, both with their own shortcomings: inactive (which was irreversible) and paused (reversible, but swallowing logs). Furthermore, there was no way of resetting the statistics, so a very bad solution was implemented (243c0f18da) that would create a new logger for each line of the repl, leaking the previous one and discarding the value of printBuildLogs. Finally, if stderr was not attached to a TTY, the update thread was started even though the logger was not active, violating the invariant required by the destructor (which is not observed because the logger is leaked). In this commit, the two aforementioned states are unified into a single one, which can be exited again, correctly upholds the invariant that the update thread is only running while the progress bar is active, and does not swallow logs. The latter change in behavior is not expected to be a problems in the rare cases where the paused state was used before, since other loggers (like the simple one) don't exhibit it anyway. The startProgressBar/stopProgressBar API is removed due to being a footgun, and a new method for properly resetting the progress is added. Co-Authored-By: Qyriad <qyriad@qyriad.me> Change-Id:I2b7c3eb17d439cd0c16f7b896cfb61239ac7ff3a
59 lines
1.4 KiB
C++
59 lines
1.4 KiB
C++
#include "command.hh"
|
|
#include "shared.hh"
|
|
#include "eval.hh"
|
|
#include "attr-path.hh"
|
|
#include "editor-for.hh"
|
|
#include "current-process.hh"
|
|
|
|
#include <unistd.h>
|
|
|
|
using namespace nix;
|
|
|
|
struct CmdEdit : InstallableCommand
|
|
{
|
|
std::string description() override
|
|
{
|
|
return "open the Nix expression of a Nix package in $EDITOR";
|
|
}
|
|
|
|
std::string doc() override
|
|
{
|
|
return
|
|
#include "edit.md"
|
|
;
|
|
}
|
|
|
|
Category category() override { return catSecondary; }
|
|
|
|
void run(ref<Store> store, ref<Installable> installable) override
|
|
{
|
|
auto state = getEvalState();
|
|
|
|
auto const installableValue = InstallableValue::require(installable);
|
|
|
|
const auto [file, line] = [&] {
|
|
auto [v, pos] = installableValue->toValue(*state);
|
|
|
|
try {
|
|
return findPackageFilename(*state, *v, installable->what());
|
|
} catch (NoPositionInfo &) {
|
|
throw Error("cannot find position information for '%s", installableValue->what());
|
|
}
|
|
}();
|
|
|
|
logger->pause();
|
|
|
|
auto args = editorFor(file, line);
|
|
|
|
restoreProcessContext();
|
|
|
|
execvp(args.front().c_str(), stringsToCharPtrs(args).data());
|
|
|
|
std::string command;
|
|
for (const auto &arg : args) command += " '" + arg + "'";
|
|
throw SysError("cannot run command%s", command);
|
|
}
|
|
};
|
|
|
|
static auto rCmdEdit = registerCommand<CmdEdit>("edit");
|