lix/tests/unit
jade 0cc285f87b
treewide: fix a bunch of lints
Fixes:
- Identifiers starting with _ are prohibited
- Some driveby header dependency cleaning which wound up with doing some
  extra fixups.
- Fucking C style casts, man. C++ made these 1000% worse by letting you
  also do memory corruption with them with references.
  - Remove casts to Expr * where ExprBlackHole is an incomplete type by
    introducing an explicitly-cast eBlackHoleAddr as Expr *.
  - An incredibly illegal cast of the text bytes of the StorePath hash
    into a size_t directly. You can't DO THAT.

    Replaced with actually parsing the hash so we get 100% of the bits
    being entropy, then memcpying the start of the hash. If this shows
    up in a profile we should just make the hash parser faster with a
    lookup table or something sensible like that.
  - This horrendous bit of UB which I thankfully slapped a deprecation
    warning on, built, and it didn't trigger anywhere so it was dead
    code and I just deleted it. But holy crap you *cannot* do that.

    inline void mkString(const Symbol & s)
    {
        mkString(((const std::string &) s).c_str());
    }
- Some wrong lints. Lots of wrong macro lints, one wrong
  suspicious-sizeof lint triggered by the template being instantiated
  with only pointers, but the calculation being correct for both
  pointers and not-pointers.
- Exceptions in destructors strike again. I tried to catch the
  exceptions that might actually happen rather than all the exceptions
  imaginable. We can let the runtime hard-kill it on other exceptions
  imo.

Change-Id: I71761620846cba64d66ee7ca231b20c061e69710
2024-08-26 16:13:03 -07:00
..
libcmd util.hh: Delete remaining file and clean up headers 2024-05-29 12:38:51 +02:00
libexpr libexpr: Deprecate URL literals 2024-08-17 20:31:57 +02:00
libexpr-support/tests libexpr: Introduce Deprecated features 2024-08-17 19:47:51 +02:00
libmain tree-wide: unify progress bar inactive and paused states 2024-07-01 18:19:34 +02:00
libstore tree-wide: fix a pile of lints 2024-08-08 14:53:17 -07:00
libstore-support/tests util.hh: Delete remaining file and clean up headers 2024-05-29 12:38:51 +02:00
libutil treewide: fix a bunch of lints 2024-08-26 16:13:03 -07:00
libutil-support/tests refactor: make HashType and Base enum classes for type safety 2024-08-08 14:53:17 -07:00
meson.build tree-wide: add support for asan! 2024-07-31 14:13:39 -07:00