5 commits

Author	SHA1	Message	Date
jade	103cd44a04	Include rearrangement: rest ... Change-Id: If9b5502ff348d358d7007b885e26e98a0d228f39	2024-11-18 12:31:19 -08:00
eldritch horrors	38dc6f5b69	Revert "libutil: drop Pool resources on exceptional free" ... This reverts commit de2884b82b. Change-Id: I1fa301149d7c2ed3d266a40c15b2d010e12e44e6	2024-04-05 20:13:02 +00:00
eldritch horrors	862f20a4ba	libutil: remove Pool::flushBad ... this was never actually used, and bad design in the first place—why should a bad resource be put back into the idle pool? just drop it. Change-Id: Idab8774bee19dadae0209d404c4fb86dd4aeba1e	2024-03-31 00:07:09 +00:00
eldritch horrors	620de98d0c	libutil: drop Pool resources on exceptional free ... if a scope owning a resource does not gracefully drop that resource while handling exceptions from deeper down the call stack we should assume the resource is invalid state and drop it. currently it *is* true that such cases do not cause resources to be freed, but thanks to validator misuses this has so far not caused any larger problem. Change-Id: Ie4f91bcd60a64d05c5ff9d22cc97954816d13b97	2024-03-30 23:40:45 +00:00
John Ericson	f7f37035c8	Move tests to separate directories, and document ... Today, with the tests inside a `tests` intermingled with the corresponding library's source code, we have a few problems: - We have to be careful that wildcards don't end up with tests being built as part of Nix proper, or test headers being installed as part of Nix proper. - Tests in libraries but not executables is not right: - It means each executable runs the previous unit tests again, because it needs the libraries. - It doesn't work right on Windows, which doesn't want you to load a DLL just for the side global variable . It could be made to work with the dlopen equivalent, but that's gross! This reorg solves these problems. There is a remaining problem which is that sibbling headers (like `hash.hh` the test header vs `hash.hh` the main `libnixutil` header) end up shadowing each other. This PR doesn't solve that. That is left as future work for a future PR. Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io> (cherry picked from commit 91b6833686a6a6d9eac7f3f66393ec89ef1d3b57) (cherry picked from commit a61e42adb528b3d40ce43e07c79368d779a8b624)	2023-12-01 13:05:03 -05:00

Renamed from src/libutil/tests/pool.cc (Browse further)