forked from lix-project/lix
Jade Lovelace
0cc285f87b
Fixes:
- Identifiers starting with _ are prohibited
- Some driveby header dependency cleaning which wound up with doing some
extra fixups.
- Fucking C style casts, man. C++ made these 1000% worse by letting you
also do memory corruption with them with references.
- Remove casts to Expr * where ExprBlackHole is an incomplete type by
introducing an explicitly-cast eBlackHoleAddr as Expr *.
- An incredibly illegal cast of the text bytes of the StorePath hash
into a size_t directly. You can't DO THAT.
Replaced with actually parsing the hash so we get 100% of the bits
being entropy, then memcpying the start of the hash. If this shows
up in a profile we should just make the hash parser faster with a
lookup table or something sensible like that.
- This horrendous bit of UB which I thankfully slapped a deprecation
warning on, built, and it didn't trigger anywhere so it was dead
code and I just deleted it. But holy crap you *cannot* do that.
inline void mkString(const Symbol & s)
{
mkString(((const std::string &) s).c_str());
}
- Some wrong lints. Lots of wrong macro lints, one wrong
suspicious-sizeof lint triggered by the template being instantiated
with only pointers, but the calculation being correct for both
pointers and not-pointers.
- Exceptions in destructors strike again. I tried to catch the
exceptions that might actually happen rather than all the exceptions
imaginable. We can let the runtime hard-kill it on other exceptions
imo.
Change-Id: I71761620846cba64d66ee7ca231b20c061e69710
32 lines
943 B
C++
32 lines
943 B
C++
#pragma once
|
|
///@file
|
|
|
|
// not used, but will be used by callers
|
|
#include <variant>
|
|
|
|
/**
|
|
* Force the default versions of all constructors (copy, move, copy
|
|
* assignment).
|
|
*/
|
|
// NOLINTBEGIN(bugprone-macro-parentheses)
|
|
#define FORCE_DEFAULT_CONSTRUCTORS(CLASS_NAME) \
|
|
CLASS_NAME(const CLASS_NAME &) = default; \
|
|
CLASS_NAME(CLASS_NAME &) = default; \
|
|
CLASS_NAME(CLASS_NAME &&) = default; \
|
|
\
|
|
CLASS_NAME & operator =(const CLASS_NAME &) = default; \
|
|
CLASS_NAME & operator =(CLASS_NAME &) = default;
|
|
// NOLINTEND(bugprone-macro-parentheses)
|
|
|
|
/**
|
|
* Make a wrapper constructor. All args are forwarded to the
|
|
* construction of the "raw" field. (Which we assume is the only one.)
|
|
*
|
|
* The moral equivalent of `using Raw::Raw;`
|
|
*/
|
|
#define MAKE_WRAPPER_CONSTRUCTOR(CLASS_NAME) \
|
|
FORCE_DEFAULT_CONSTRUCTORS(CLASS_NAME) \
|
|
\
|
|
CLASS_NAME(auto &&... arg) \
|
|
: raw(std::forward<decltype(arg)>(arg)...) \
|
|
{ }
|