emilytrau/lix
1
0
Fork 0
forked from lix-project/lix
Code Pull requests Activity
11226 commits 12 branches 0 tags 64 MiB
Commit graph

11226 commits

This branch
This branch
All branches
Author SHA1 Message Date
Geoff Reedy 9d67332e4b Better eval error locations for interpolation and + 
Previously, type or coercion errors for string interpolation, path
interpolation, and plus expressions were always reported at the
beginning of the outer expression. This leads to confusing evaluation
error messages making it hard to accurately diagnose and then fix the
error.

For example, errors were reported as follows.

```
cannot coerce an integer to a string
1| let foo = 7; in "bar" + foo
 |                 ^

cannot add a string to an integer
1| let foo = "bar"; in 4 + foo
 |                     ^

cannot coerce an integer to a string
1| let foo = 7; in "x${foo}"
 |                  ^
```

This commit changes the ExprConcatStrings expression vector to store a
sequence of expressions *and* their expansion locations so that error
locations can be reported accurately. For interpolation, the error is
reported at the beginning of the entire `${foo}`, not at the beginning
of `foo` because I thought this was slightly clearer. The previous
errors are now reported as:

```
cannot coerce an integer to a string
1| let foo = 7; in "bar" + foo
 |                         ^

cannot add a string to an integer
1| let foo = "bar"; in 4 + foo
 |                         ^

cannot coerce an integer to a string
1| let foo = 7; in "x${foo}"
 |                   ^
```

The error is reported at this kind of precise location even for
multi-line indented strings.

This probably helps with at least some of the cases mentioned in #561
 2021-09-22 20:57:34 -06:00
Eelco Dolstra d1bf7431bb Revert "Merge pull request #4922 from nrdxp/default-submodules" 
This reverts commit 6678e98411, reversing
changes made to 90b2dd570c.
 2021-09-22 17:25:25 +02:00
Eelco Dolstra 8623a5b595 Disable IFD selectively 
It's now disabled by default for the following:

* 'nix search' (this was already implied by read-only mode)
* 'nix flake show'
* 'nix flake check', but only on the hydraJobs output
 2021-09-22 17:15:07 +02:00
Eelco Dolstra d8c10028d9 Make setDefault() typed 2021-09-22 14:15:35 +02:00
Eelco Dolstra 8fdb1d057a Quiet 2021-09-22 14:12:31 +02:00
Eelco Dolstra ff28fffce2 Don't cache realiseContext() errors 
Errors that depend on the configuration (such as whether
allow-import-from-derivation is set) should not be cached.
 2021-09-22 14:00:56 +02:00
Eelco Dolstra bcd73ebf60 Add missing #include 
Fixes #5282.
 2021-09-22 12:14:50 +02:00
Eelco Dolstra 3c1cd09109
Merge pull request #5281 from abathur/install_macos_monterey 
fix install on macOS monterey
 2021-09-22 10:58:02 +02:00
Travis A. Everett 033081aec2 fix install on macOS monterey 2021-09-21 13:38:29 -05:00
Eelco Dolstra c81f9761cc
Merge pull request #5279 from edolstra/restrict-path-inputs 
Fix relative path input handling
 2021-09-21 14:52:30 +02:00
Eelco Dolstra 60cc975d22 Set input parent at construction time 2021-09-21 14:07:16 +02:00
Eelco Dolstra 06557299b3 Allow relative paths anywhere into the parent's store path 2021-09-21 13:45:11 +02:00
Eelco Dolstra 5cbb9c5406 path fetcher: Fix relative path check 2021-09-21 13:19:26 +02:00
Eelco Dolstra be69a98d2c
Merge pull request #5277 from NixOS/regnat/ci-better-cache-usage 
flake: Use the real nixUnstable from nixpkgs
 2021-09-20 15:48:32 +02:00
regnat 81ed6ee201 flake: Use the real nixUnstable from nixpkgs 
Don’t let it pick our overriden lowdown as that would cause it not to be
cached in cache.nixos.org
 2021-09-20 14:37:09 +02:00
Eelco Dolstra 2933d3c588
Merge pull request #5266 from gkleen/fix/s3-cache-scheme 
Fix scheme query parameter for s3 cache
 2021-09-20 12:16:53 +02:00
Michael Bishop 374fe49ff7 set the PER_LINUX32 personality flag, when building for armv6l-linux or armv7l-linux 
this prevents 32bit builds from detecting a 64bit kernel and picking the wrong target
 2021-09-19 23:07:10 -03:00
Gregor Kleen fd67a0f927 Fix scheme argument to s3 cache 2021-09-17 10:45:19 +02:00
Eelco Dolstra 37cc50f2c8
Merge pull request #5263 from greedy/fix-5261 
Include subpath in flake fingerprint
 2021-09-17 08:10:47 +02:00
Geoff Reedy cbe9ddfd1a Include subpath in flake fingerprint 
Without this, flakes within the same tree and same lock data will have
the same fingerprint and the eval cache for one flake will be
incorrectly used for another.
 2021-09-16 15:58:21 -06:00
Eelco Dolstra 1ec4efa6c8
Merge pull request #5257 from edolstra/dirty-lock-file 
If we can't write a lock file, pretend the top-level flake is dirty
 2021-09-15 20:18:23 +02:00
Eelco Dolstra c17f3c5e69 Merge branch 'mh/fix-chroot-eval' of https://github.com/obsidiansystems/nix 2021-09-15 18:37:58 +02:00
Eelco Dolstra 027344ce7e If we can't write a lock file, pretend the top-level flake is dirty 
Alternative to #4639. You can still read flake.lock, but at least in
reproducible workflows like NixOS configurations where you require a
non-dirty tree, evaluation will fail because there is no rev.
 2021-09-15 18:31:42 +02:00
Eelco Dolstra 991cc53386 Revert "Disallow reading flake.lock" 
This reverts commit e5596113f7.
 2021-09-15 18:30:37 +02:00
Eelco Dolstra d2c8eed344
Merge pull request #5251 from emilazy/darwin-sandbox-rosetta-2 
sandbox: allow Rosetta 2 on Darwin
 2021-09-15 09:11:26 +02:00
Emily 56025ad3b1 sandbox: allow Rosetta 2 on Darwin 
This allows sandboxed x86_64-darwin builds on aarch64-darwin.
 2021-09-15 02:02:03 +01:00
Eelco Dolstra fda4efff87 Rename unnecessary git@ 2021-09-14 22:53:31 +02:00
Eelco Dolstra 5ee3ee1a6b
Merge pull request #5249 from edolstra/nix-profile 
Add missing 'nix profile' subcommands
 2021-09-14 22:27:19 +02:00
Eelco Dolstra 2c751c0c00
Merge pull request #5250 from edolstra/censor-flake-lock 
Disallow reading flake.lock
 2021-09-14 22:27:02 +02:00
Eelco Dolstra e5596113f7 Disallow reading flake.lock 
With --no-write-lock-file, it's possible that flake.lock is out of
sync with the actual inputs used by the evaluation. So doing fromJSON
(readFile ./flake.lock) will give wrong results.

Fixes #4639.
 2021-09-14 21:09:11 +02:00
Eelco Dolstra b41968f15a nix profile history: Show profile date 2021-09-14 20:47:33 +02:00
Eelco Dolstra 4b738fc7a9 Add 'nix profile wipe-history' command 2021-09-14 20:35:41 +02:00
Eelco Dolstra f359b9981b Generations -> profile versions 2021-09-14 19:57:45 +02:00
Eelco Dolstra 229ad612b8 Fix quotes 2021-09-14 19:48:16 +02:00
Eelco Dolstra 817562e694 Add "nix profile rollback" command 2021-09-14 19:32:33 +02:00
Eelco Dolstra 1fbaf36729 nix flake show --json: Add type info 
For extensibility, every leaf node is now an object that contains at
least a type field (e.g. "type": "derivation").
 2021-09-14 17:18:29 +02:00
Eelco Dolstra f3259af73e Merge branch 'tomberek/show_json' of https://github.com/tomberek/nix 2021-09-14 16:58:35 +02:00
Domen Kožar 275cb44f9f
Merge pull request #5242 from NixOS/dependabot/github_actions/cachix/install-nix-action-14 
Bump cachix/install-nix-action from 13 to 14
 2021-09-14 16:04:18 +02:00
Eelco Dolstra d589a6aa8a
Merge pull request #5247 from edolstra/stablize-ca-references 
Remove the 'ca-references' feature check
 2021-09-14 15:42:50 +02:00
Eelco Dolstra 75837bb595 Respect NO_COLOR in Markdown output 2021-09-14 14:57:58 +02:00
dependabot[bot] 5052a81bba
Bump cachix/install-nix-action from 13 to 14 
Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 13 to 14.
- [Release notes](https://github.com/cachix/install-nix-action/releases)
- [Commits](https://github.com/cachix/install-nix-action/compare/v13...v14)

---
updated-dependencies:
- dependency-name: cachix/install-nix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-09-14 12:57:56 +00:00
Eelco Dolstra 7e4dd0e279
Merge pull request #5248 from edolstra/flake-clone 
Fix 'nix flake clone' on github repos
 2021-09-14 14:14:59 +02:00
Eelco Dolstra 01a4fa3b6e Advise using --extra-experimental-features instead of --experimental-features 
Fixes #3737.
 2021-09-14 13:56:36 +02:00
Eelco Dolstra 761ac9d584 Remove the 'ca-references' feature check 
Fixes #3422.
Fixes #4425.
 2021-09-14 13:53:20 +02:00
Eelco Dolstra 07996c4810 github fetcher: Don't use HEAD branch when cloning 
Fixes #4394.
 2021-09-14 13:38:45 +02:00
Eelco Dolstra d72d31d529 github fetcher: Use git+https for cloning 
git+ssh only works if you have SSH access.
 2021-09-14 13:38:05 +02:00
Eelco Dolstra e664270c2b
Merge pull request #5246 from edolstra/faster-check 
Speed up 'nix flake check'
 2021-09-14 12:22:28 +02:00
Eelco Dolstra a4ae601b44
Merge pull request #5245 from edolstra/warnings 
Change warning messages from yellow to magenta
 2021-09-14 11:46:34 +02:00
Eelco Dolstra 2cf8110f5a flake.nix: Don't do cross builds in 'nix flake check' 
'nix flake check' should be relatively fast, so it's not the best
place to do cross-builds. We're already doing that in Hydra.
 2021-09-14 11:34:32 +02:00
Eelco Dolstra 6ff19ce137 nix-tests: Run 'make installcheck' in parallel 2021-09-14 11:34:17 +02:00