From 3272a2d26fd24647509cddfc2267310416a41cd1 Mon Sep 17 00:00:00 2001 From: Robert Hensing Date: Wed, 18 Jan 2023 12:16:27 +0100 Subject: [PATCH 1/2] maintainers: Document backporting quirk Closes #7623 --- maintainers/backporting.md | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 maintainers/backporting.md diff --git a/maintainers/backporting.md b/maintainers/backporting.md new file mode 100644 index 000000000..fe860bc61 --- /dev/null +++ b/maintainers/backporting.md @@ -0,0 +1,8 @@ + +# Backporting + +Backports are handled by the backport action. + +Since GitHub Actions can not trigger actions, the backport PR needs to be re-triggered by another actor. This is achieved by closing and reopening the backport PR. + +This specifically affects the `installer_test` check, but note that it only runs after the other tests, so it may take a while to appear. From 40d8955b8977c19de5cf837a2711621b84b7375b Mon Sep 17 00:00:00 2001 From: Robert Hensing Date: Wed, 8 Feb 2023 00:24:28 +0100 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Valentin Gagarin --- maintainers/backporting.md | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/maintainers/backporting.md b/maintainers/backporting.md index fe860bc61..2424050c8 100644 --- a/maintainers/backporting.md +++ b/maintainers/backporting.md @@ -1,8 +1,12 @@ # Backporting -Backports are handled by the backport action. +To [automatically backport a pull request](https://github.com/NixOS/nix/blob/master/.github/workflows/backport.yml) to a release branch once it's merged, assign it a label of the form [`backport `](https://github.com/NixOS/nix/labels?q=backport). -Since GitHub Actions can not trigger actions, the backport PR needs to be re-triggered by another actor. This is achieved by closing and reopening the backport PR. +Since [GitHub Actions workflows will not trigger other workflows](https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow), checks on the automatic backport need to be triggered by another actor. +This is achieved by closing and reopening the backport pull request. -This specifically affects the `installer_test` check, but note that it only runs after the other tests, so it may take a while to appear. +This specifically affects the [`installer_test`] check. +Note that it only runs after the other tests, so it may take a while to appear. + +[`installer_test`]: https://github.com/NixOS/nix/blob/895dfc656a21f6252ddf48df0d1f215effa04ecb/.github/workflows/ci.yml#L70-L91