eisfunke/lix
0
0
Fork 0
forked from lix-project/lix
Code Pull requests Activity

nix doctor: add check for profile roots

Browse source 
In most cases profiles that are in PATH should have a gcroot.
This commit is contained in:
Daiderd Jordan 2018-09-02 12:52:04 +02:00
parent 0f18dc5479
commit bfdca55868
No known key found for this signature in database
GPG key ID: D02435D05B810C96
1 changed files with 35 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
src/nix/doctor.cc
View file

@ -34,6 +34,7 @@ struct CmdDoctor : StoreCommand
std::cout << std::endl; std::cout << std::endl;
checkNixInPath(); checkNixInPath();
checkProfileRoots(store);
checkStoreProtocol(store->getProtocol()); checkStoreProtocol(store->getProtocol());
} }
@ -53,6 +54,40 @@ struct CmdDoctor : StoreCommand
} }
} }
void checkProfileRoots(ref<Store> store) {
PathSet dirs;
Roots roots = store->findRoots();
for (auto & dir : tokenizeString<Strings>(getEnv("PATH"), ":"))
try {
auto profileDir = canonPath(dirOf(dir), true);
if (hasSuffix(profileDir, "user-environment") &&
store->isValidPath(profileDir)) {
PathSet referrers;
store->computeFSClosure({profileDir}, referrers, true,
settings.gcKeepOutputs, settings.gcKeepDerivations);
bool found = false;
for (auto & i : roots)
if (referrers.find(i.second) != referrers.end())
found = true;
if (!found)
dirs.insert(dir);
}
} catch (SysError &) {}
if (!dirs.empty()) {
std::cout << "Warning: found profiles without a gcroot." << std::endl;
std::cout << "The generation this profile points to will be deleted with the next gc, resulting" << std::endl;
std::cout << "in broken symlinks. Make sure your profiles are in " << settings.nixStateDir << "/profiles." << std::endl;
std::cout << std::endl;
for (auto & dir : dirs)
std::cout << " " << dir << std::endl;
std::cout << std::endl;
}
}
void checkStoreProtocol(unsigned int storeProto) { void checkStoreProtocol(unsigned int storeProto) {
auto clientProto = GET_PROTOCOL_MAJOR(SERVE_PROTOCOL_VERSION) == GET_PROTOCOL_MAJOR(storeProto) auto clientProto = GET_PROTOCOL_MAJOR(SERVE_PROTOCOL_VERSION) == GET_PROTOCOL_MAJOR(storeProto)
? SERVE_PROTOCOL_VERSION ? SERVE_PROTOCOL_VERSION