From 91ef4d9a81827177963bcf7708af3a46217fd0e9 Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Fri, 9 Nov 2012 14:43:47 +0100 Subject: [PATCH] Remove unnecessary call to closeMostFDs() We have close-on-exec on all FDs now, and there is no security risk in passing open FDs to substituters anyway. --- src/libstore/local-store.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libstore/local-store.cc b/src/libstore/local-store.cc index b82c03f59..138010f87 100644 --- a/src/libstore/local-store.cc +++ b/src/libstore/local-store.cc @@ -983,7 +983,6 @@ void LocalStore::startSubstituter(const Path & substituter, RunningSubstituter & throw SysError("dupping stdout"); if (dup2(errorPipe.writeSide, STDERR_FILENO) == -1) throw SysError("dupping stderr"); - closeMostFDs(set()); execl(substituter.c_str(), substituter.c_str(), "--query", NULL); throw SysError(format("executing `%1%'") % substituter); } catch (std::exception & e) {