From 438977731cf049cf47873d5825456d47a1aac541 Mon Sep 17 00:00:00 2001
From: regnat <rg@regnat.ovh>
Date: Tue, 1 Dec 2020 14:57:56 +0100
Subject: [PATCH] shut up clang warnings

- Fix some class/struct discrepancies
- Explicit the overloading of `run` in the `Cmd*` classes
- Ignore a warning in the generated lexer
---
 src/libexpr/lexer.l          | 2 ++
 src/libstore/build/goal.hh   | 2 +-
 src/libstore/build/worker.hh | 4 ++--
 src/libstore/local-store.hh  | 4 ++--
 src/nix/run.cc               | 8 ++++++++
 5 files changed, 15 insertions(+), 5 deletions(-)

diff --git a/src/libexpr/lexer.l b/src/libexpr/lexer.l
index f6e83926b..225ab3287 100644
--- a/src/libexpr/lexer.l
+++ b/src/libexpr/lexer.l
@@ -12,6 +12,8 @@
 
 
 %{
+#pragma clang diagnostic ignored "-Wunneeded-internal-declaration"
+
 #include <boost/lexical_cast.hpp>
 
 #include "nixexpr.hh"
diff --git a/src/libstore/build/goal.hh b/src/libstore/build/goal.hh
index 0781a9d38..fca4f2d00 100644
--- a/src/libstore/build/goal.hh
+++ b/src/libstore/build/goal.hh
@@ -7,7 +7,7 @@ namespace nix {
 
 /* Forward definition. */
 struct Goal;
-struct Worker;
+class Worker;
 
 /* A pointer to a goal. */
 typedef std::shared_ptr<Goal> GoalPtr;
diff --git a/src/libstore/build/worker.hh b/src/libstore/build/worker.hh
index 3a53a8def..bf8cc4586 100644
--- a/src/libstore/build/worker.hh
+++ b/src/libstore/build/worker.hh
@@ -8,8 +8,8 @@
 namespace nix {
 
 /* Forward definition. */
-class DerivationGoal;
-class SubstitutionGoal;
+struct DerivationGoal;
+struct SubstitutionGoal;
 
 /* Workaround for not being able to declare a something like
 
diff --git a/src/libstore/local-store.hh b/src/libstore/local-store.hh
index d4435220d..58ec93f27 100644
--- a/src/libstore/local-store.hh
+++ b/src/libstore/local-store.hh
@@ -296,8 +296,8 @@ private:
 
     void createUser(const std::string & userName, uid_t userId) override;
 
-    friend class DerivationGoal;
-    friend class SubstitutionGoal;
+    friend struct DerivationGoal;
+    friend struct SubstitutionGoal;
 };
 
 
diff --git a/src/nix/run.cc b/src/nix/run.cc
index 790784382..92a52c6cd 100644
--- a/src/nix/run.cc
+++ b/src/nix/run.cc
@@ -22,6 +22,9 @@ std::string chrootHelperName = "__run_in_chroot";
 
 struct RunCommon : virtual Command
 {
+
+    using Command::run;
+
     void runProgram(ref<Store> store,
         const std::string & program,
         const Strings & args)
@@ -59,6 +62,9 @@ struct RunCommon : virtual Command
 
 struct CmdShell : InstallablesCommand, RunCommon, MixEnvironment
 {
+
+    using InstallablesCommand::run;
+
     std::vector<std::string> command = { getEnv("SHELL").value_or("bash") };
 
     CmdShell()
@@ -144,6 +150,8 @@ static auto rCmdShell = registerCommand<CmdShell>("shell");
 
 struct CmdRun : InstallableCommand, RunCommon
 {
+    using InstallableCommand::run;
+
     std::vector<std::string> args;
 
     CmdRun()