Controller/{Jobset,Project}: error when enabling dynamic runcommand but it's disabled elsewhere
This commit is contained in:
Cole Helbling
Graham Christensen
parent
d680c209fe
commit
928ba9e854
|
|
@ -261,6 +261,14 @@ sub updateJobset {
|
|||
|
||||
my $checkinterval = int(trim($c->stash->{params}->{checkinterval}));
|
||||
|
||||
my $enable_dynamic_run_command = defined $c->stash->{params}->{enable_dynamic_run_command} ? 1 : 0;
|
||||
if ($enable_dynamic_run_command
|
||||
&& !($c->config->{dynamicruncommand}->{enable}
|
||||
&& $jobset->project->enable_dynamic_run_command))
|
||||
{
|
||||
badRequest($c, "Dynamic RunCommand is not enabled by the server or the parent project.");
|
||||
}
|
||||
|
||||
$jobset->update(
|
||||
{ name => $jobsetName
|
||||
, description => trim($c->stash->{params}->{"description"})
|
||||
|
|
@ -268,7 +276,7 @@ sub updateJobset {
|
|||
, nixexprinput => $nixExprInput
|
||||
, enabled => $enabled
|
||||
, enableemail => defined $c->stash->{params}->{enableemail} ? 1 : 0
|
||||
, enable_dynamic_run_command => defined $c->stash->{params}->{enable_dynamic_run_command} ? 1 : 0
|
||||
, enable_dynamic_run_command => $enable_dynamic_run_command
|
||||
, emailoverride => trim($c->stash->{params}->{emailoverride}) || ""
|
||||
, hidden => defined $c->stash->{params}->{visible} ? 0 : 1
|
||||
, keepnr => int(trim($c->stash->{params}->{keepnr} // "0"))
|
||||
|
|
|
|||
|
|
@ -149,6 +149,11 @@ sub updateProject {
|
|||
my $displayName = trim $c->stash->{params}->{displayname};
|
||||
error($c, "You must specify a display name.") if $displayName eq "";
|
||||
|
||||
my $enable_dynamic_run_command = defined $c->stash->{params}->{enable_dynamic_run_command} ? 1 : 0;
|
||||
if ($enable_dynamic_run_command && !$c->config->{dynamicruncommand}->{enable}) {
|
||||
badRequest($c, "Dynamic RunCommand is not enabled by the server.");
|
||||
}
|
||||
|
||||
$project->update(
|
||||
{ name => $projectName
|
||||
, displayname => $displayName
|
||||
|
|
@ -157,7 +162,7 @@ sub updateProject {
|
|||
, enabled => defined $c->stash->{params}->{enabled} ? 1 : 0
|
||||
, hidden => defined $c->stash->{params}->{visible} ? 0 : 1
|
||||
, owner => $owner
|
||||
, enable_dynamic_run_command => defined $c->stash->{params}->{enable_dynamic_run_command} ? 1 : 0
|
||||
, enable_dynamic_run_command => $enable_dynamic_run_command
|
||||
, declfile => trim($c->stash->{params}->{declarative}->{file})
|
||||
, decltype => trim($c->stash->{params}->{declarative}->{type})
|
||||
, declvalue => trim($c->stash->{params}->{declarative}->{value})
|
||||
|
|
|
|||
110
t/Hydra/Plugin/RunCommand/dynamic-disabled.t
Normal file
110
t/Hydra/Plugin/RunCommand/dynamic-disabled.t
Normal file
|
|
@ -0,0 +1,110 @@
|
|||
use strict;
|
||||
use warnings;
|
||||
use Setup;
|
||||
use Test2::V0;
|
||||
|
||||
require Catalyst::Test;
|
||||
use HTTP::Request::Common qw(POST PUT GET DELETE);
|
||||
use JSON::MaybeXS qw(decode_json encode_json);
|
||||
|
||||
my $ctx = test_context();
|
||||
Catalyst::Test->import('Hydra');
|
||||
|
||||
# Create a user to log in to
|
||||
my $user = $ctx->db->resultset('Users')->create({ username => 'alice', emailaddress => 'root@invalid.org', password => '!' });
|
||||
$user->setPassword('foobar');
|
||||
$user->userroles->update_or_create({ role => 'admin' });
|
||||
|
||||
subtest "can't enable dynamic RunCommand when disabled by server" => sub {
|
||||
my $builds = $ctx->makeAndEvaluateJobset(
|
||||
expression => "runcommand-dynamic.nix",
|
||||
build => 1
|
||||
);
|
||||
|
||||
my $build = $builds->{"runCommandHook.example"};
|
||||
my $project = $build->project;
|
||||
my $project_name = $project->name;
|
||||
my $jobset = $build->jobset;
|
||||
my $jobset_name = $jobset->name;
|
||||
|
||||
is($project->enable_dynamic_run_command, 0, "dynamic RunCommand is disabled on projects by default");
|
||||
is($jobset->enable_dynamic_run_command, 0, "dynamic RunCommand is disabled on jobsets by default");
|
||||
|
||||
my $req = request(POST '/login',
|
||||
Referer => 'http://localhost/',
|
||||
Content => {
|
||||
username => 'alice',
|
||||
password => 'foobar'
|
||||
}
|
||||
);
|
||||
is($req->code, 302, "logged in successfully");
|
||||
my $cookie = $req->header("set-cookie");
|
||||
|
||||
subtest "can't enable dynamic RunCommand on project" => sub {
|
||||
my $projectresponse = request(GET "/project/$project_name",
|
||||
Accept => 'application/json',
|
||||
Content_Type => 'application/json',
|
||||
Cookie => $cookie,
|
||||
);
|
||||
|
||||
my $projectjson = decode_json($projectresponse->content);
|
||||
$projectjson->{enable_dynamic_run_command} = 1;
|
||||
|
||||
my $projectupdate = request(PUT "/project/$project_name",
|
||||
Accept => 'application/json',
|
||||
Content_Type => 'application/json',
|
||||
Cookie => $cookie,
|
||||
Content => encode_json($projectjson)
|
||||
);
|
||||
|
||||
$projectresponse = request(GET "/project/$project_name",
|
||||
Accept => 'application/json',
|
||||
Content_Type => 'application/json',
|
||||
Cookie => $cookie,
|
||||
);
|
||||
$projectjson = decode_json($projectresponse->content);
|
||||
|
||||
is($projectupdate->code, 400);
|
||||
like(
|
||||
$projectupdate->content,
|
||||
qr/Dynamic RunCommand is not/,
|
||||
"failed to change enable_dynamic_run_command, not any other error"
|
||||
);
|
||||
is($projectjson->{enable_dynamic_run_command}, JSON::MaybeXS::false);
|
||||
};
|
||||
|
||||
subtest "can't enable dynamic RunCommand on jobset" => sub {
|
||||
my $jobsetresponse = request(GET "/jobset/$project_name/$jobset_name",
|
||||
Accept => 'application/json',
|
||||
Content_Type => 'application/json',
|
||||
Cookie => $cookie,
|
||||
);
|
||||
|
||||
my $jobsetjson = decode_json($jobsetresponse->content);
|
||||
$jobsetjson->{enable_dynamic_run_command} = 1;
|
||||
|
||||
my $jobsetupdate = request(PUT "/jobset/$project_name/$jobset_name",
|
||||
Accept => 'application/json',
|
||||
Content_Type => 'application/json',
|
||||
Cookie => $cookie,
|
||||
Content => encode_json($jobsetjson)
|
||||
);
|
||||
|
||||
$jobsetresponse = request(GET "/jobset/$project_name/$jobset_name",
|
||||
Accept => 'application/json',
|
||||
Content_Type => 'application/json',
|
||||
Cookie => $cookie,
|
||||
);
|
||||
$jobsetjson = decode_json($jobsetresponse->content);
|
||||
|
||||
is($jobsetupdate->code, 400);
|
||||
like(
|
||||
$jobsetupdate->content,
|
||||
qr/Dynamic RunCommand is not/,
|
||||
"failed to change enable_dynamic_run_command, not any other error"
|
||||
);
|
||||
is($jobsetjson->{enable_dynamic_run_command}, JSON::MaybeXS::false);
|
||||
};
|
||||
};
|
||||
|
||||
done_testing;
|
||||
106
t/Hydra/Plugin/RunCommand/dynamic-enabled.t
Normal file
106
t/Hydra/Plugin/RunCommand/dynamic-enabled.t
Normal file
|
|
@ -0,0 +1,106 @@
|
|||
use strict;
|
||||
use warnings;
|
||||
use Setup;
|
||||
use Test2::V0;
|
||||
|
||||
require Catalyst::Test;
|
||||
use HTTP::Request::Common qw(POST PUT GET DELETE);
|
||||
use JSON::MaybeXS qw(decode_json encode_json);
|
||||
|
||||
my $ctx = test_context(
|
||||
hydra_config => q|
|
||||
<dynamicruncommand>
|
||||
enable = 1
|
||||
</dynamicruncommand>
|
||||
|
|
||||
);
|
||||
Catalyst::Test->import('Hydra');
|
||||
|
||||
# Create a user to log in to
|
||||
my $user = $ctx->db->resultset('Users')->create({ username => 'alice', emailaddress => 'root@invalid.org', password => '!' });
|
||||
$user->setPassword('foobar');
|
||||
$user->userroles->update_or_create({ role => 'admin' });
|
||||
|
||||
subtest "can enable dynamic RunCommand when enabled by server" => sub {
|
||||
my $builds = $ctx->makeAndEvaluateJobset(
|
||||
expression => "runcommand-dynamic.nix",
|
||||
build => 1
|
||||
);
|
||||
|
||||
my $build = $builds->{"runCommandHook.example"};
|
||||
my $project = $build->project;
|
||||
my $project_name = $project->name;
|
||||
my $jobset = $build->jobset;
|
||||
my $jobset_name = $jobset->name;
|
||||
|
||||
is($project->enable_dynamic_run_command, 0, "dynamic RunCommand is disabled on projects by default");
|
||||
is($jobset->enable_dynamic_run_command, 0, "dynamic RunCommand is disabled on jobsets by default");
|
||||
|
||||
my $req = request(POST '/login',
|
||||
Referer => 'http://localhost/',
|
||||
Content => {
|
||||
username => 'alice',
|
||||
password => 'foobar'
|
||||
}
|
||||
);
|
||||
is($req->code, 302, "logged in successfully");
|
||||
my $cookie = $req->header("set-cookie");
|
||||
|
||||
subtest "can enable dynamic RunCommand on project" => sub {
|
||||
my $projectresponse = request(GET "/project/$project_name",
|
||||
Accept => 'application/json',
|
||||
Content_Type => 'application/json',
|
||||
Cookie => $cookie,
|
||||
);
|
||||
|
||||
my $projectjson = decode_json($projectresponse->content);
|
||||
$projectjson->{enable_dynamic_run_command} = 1;
|
||||
|
||||
my $projectupdate = request(PUT "/project/$project_name",
|
||||
Accept => 'application/json',
|
||||
Content_Type => 'application/json',
|
||||
Cookie => $cookie,
|
||||
Content => encode_json($projectjson)
|
||||
);
|
||||
|
||||
$projectresponse = request(GET "/project/$project_name",
|
||||
Accept => 'application/json',
|
||||
Content_Type => 'application/json',
|
||||
Cookie => $cookie,
|
||||
);
|
||||
$projectjson = decode_json($projectresponse->content);
|
||||
|
||||
is($projectupdate->code, 200);
|
||||
is($projectjson->{enable_dynamic_run_command}, JSON::MaybeXS::true);
|
||||
};
|
||||
|
||||
subtest "can enable dynamic RunCommand on jobset" => sub {
|
||||
my $jobsetresponse = request(GET "/jobset/$project_name/$jobset_name",
|
||||
Accept => 'application/json',
|
||||
Content_Type => 'application/json',
|
||||
Cookie => $cookie,
|
||||
);
|
||||
|
||||
my $jobsetjson = decode_json($jobsetresponse->content);
|
||||
$jobsetjson->{enable_dynamic_run_command} = 1;
|
||||
|
||||
my $jobsetupdate = request(PUT "/jobset/$project_name/$jobset_name",
|
||||
Accept => 'application/json',
|
||||
Content_Type => 'application/json',
|
||||
Cookie => $cookie,
|
||||
Content => encode_json($jobsetjson)
|
||||
);
|
||||
|
||||
$jobsetresponse = request(GET "/jobset/$project_name/$jobset_name",
|
||||
Accept => 'application/json',
|
||||
Content_Type => 'application/json',
|
||||
Cookie => $cookie,
|
||||
);
|
||||
$jobsetjson = decode_json($jobsetresponse->content);
|
||||
|
||||
is($jobsetupdate->code, 200);
|
||||
is($jobsetjson->{enable_dynamic_run_command}, JSON::MaybeXS::true);
|
||||
};
|
||||
};
|
||||
|
||||
done_testing;
|
||||
Loading…
Reference in a new issue