perlcritic: use strict, use warnings

src/Makefile.PL

@@ -1,5 +1,7 @@
 # IMPORTANT: if you delete this file your app will not work as
 # expected.  you have been warned
+use strict;
+use warnings;
 use inc::Module::Install;
 
 name 'Hydra';

src/lib/Hydra/Config.pm

@@ -1,5 +1,8 @@
 package Hydra::Config;
 
+use strict;
+use warnings;
+
 our %configGeneralOpts = (-UseApacheInclude => 1, -IncludeAgain => 1, -IncludeRelative => 1);
 
 1;

src/lib/Hydra/Event.pm

@@ -1,6 +1,7 @@
 package Hydra::Event;
 
 use strict;
+use warnings;
 use Hydra::Event::BuildFinished;
 use Hydra::Event::BuildStarted;
 use Hydra::Event::StepFinished;

src/lib/Hydra/Helper/AddBuilds.pm

@@ -1,6 +1,7 @@
 package Hydra::Helper::AddBuilds;
 
 use strict;
+use warnings;
 use utf8;
 use Encode;
 use JSON;

src/lib/Hydra/Helper/CatalystUtils.pm

@@ -2,6 +2,7 @@ package Hydra::Helper::CatalystUtils;
 
 use utf8;
 use strict;
+use warnings;
 use Exporter;
 use Readonly;
 use Nix::Store;

src/lib/Hydra/Helper/Email.pm

@@ -1,6 +1,7 @@
 package Hydra::Helper::Email;
 
 use strict;
+use warnings;
 use Email::MIME;
 use Email::Sender::Simple qw(sendmail);
 use Exporter 'import';

src/lib/Hydra/Helper/Escape.pm

@@ -1,6 +1,7 @@
 package Hydra::Helper::Escape;
 
 use strict;
+use warnings;
 use base qw(Exporter);
 use Hydra::Helper::AttributeSet;
 

src/lib/Hydra/Helper/Nix.pm

@@ -1,6 +1,7 @@
 package Hydra::Helper::Nix;
 
 use strict;
+use warnings;
 use Exporter;
 use File::Path;
 use File::Basename;

src/lib/Hydra/Model/DB.pm

@@ -1,6 +1,7 @@
 package Hydra::Model::DB;
 
 use strict;
+use warnings;
 use base 'Catalyst::Model::DBIC::Schema';
 
 sub getHydraPath {

src/lib/Hydra/Plugin.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin;
 
 use strict;
+use warnings;
 use Module::Pluggable
     search_path => "Hydra::Plugin",
     instantiate => 'new';

src/lib/Hydra/Plugin/BazaarInput.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::BazaarInput;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use Digest::SHA qw(sha256_hex);
 use File::Path;

src/lib/Hydra/Plugin/BitBucketPulls.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::BitBucketPulls;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use HTTP::Request;
 use LWP::UserAgent;

src/lib/Hydra/Plugin/BitBucketStatus.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::BitBucketStatus;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use HTTP::Request;
 use JSON;

src/lib/Hydra/Plugin/CircleCINotification.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::CircleCINotification;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use HTTP::Request;
 use LWP::UserAgent;

src/lib/Hydra/Plugin/CompressLog.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::CompressLog;
 
 use strict;
+use warnings;
 use utf8;
 use parent 'Hydra::Plugin';
 use Hydra::Helper::CatalystUtils;

src/lib/Hydra/Plugin/CoverityScan.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::CoverityScan;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use File::Basename;
 use LWP::UserAgent;

src/lib/Hydra/Plugin/DarcsInput.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::DarcsInput;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use Digest::SHA qw(sha256_hex);
 use File::Path;

src/lib/Hydra/Plugin/DeclarativeJobsets.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::DeclarativeJobsets;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use Hydra::Helper::AddBuilds;
 

src/lib/Hydra/Plugin/EmailNotification.pm

@@ -2,6 +2,7 @@ package Hydra::Plugin::EmailNotification;
 
 use utf8;
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use POSIX qw(strftime);
 use Template;

src/lib/Hydra/Plugin/GitInput.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::GitInput;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use Digest::SHA qw(sha256_hex);
 use File::Path;

src/lib/Hydra/Plugin/GiteaStatus.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::GiteaStatus;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 
 use HTTP::Request;

src/lib/Hydra/Plugin/GithubPulls.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::GithubPulls;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use HTTP::Request;
 use LWP::UserAgent;

src/lib/Hydra/Plugin/GithubRefs.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::GithubRefs;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use HTTP::Request;
 use LWP::UserAgent;

src/lib/Hydra/Plugin/GithubStatus.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::GithubStatus;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use HTTP::Request;
 use JSON;

src/lib/Hydra/Plugin/GitlabPulls.pm

@@ -15,6 +15,7 @@
 package Hydra::Plugin::GitlabPulls;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use HTTP::Request;
 use LWP::UserAgent;

src/lib/Hydra/Plugin/GitlabStatus.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::GitlabStatus;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use HTTP::Request;
 use JSON;

src/lib/Hydra/Plugin/HipChatNotification.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::HipChatNotification;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use LWP::UserAgent;
 use Hydra::Helper::CatalystUtils;

src/lib/Hydra/Plugin/InfluxDBNotification.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::InfluxDBNotification;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use HTTP::Request;
 use LWP::UserAgent;

src/lib/Hydra/Plugin/MercurialInput.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::MercurialInput;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use Digest::SHA qw(sha256_hex);
 use File::Path;

src/lib/Hydra/Plugin/PathInput.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::PathInput;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use POSIX qw(strftime);
 use Hydra::Helper::Nix;

src/lib/Hydra/Plugin/RunCommand.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::RunCommand;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use experimental 'smartmatch';
 use JSON;

src/lib/Hydra/Plugin/S3Backup.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::S3Backup;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use File::Temp;
 use File::Basename;

src/lib/Hydra/Plugin/SlackNotification.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::SlackNotification;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use HTTP::Request;
 use LWP::UserAgent;

src/lib/Hydra/Plugin/SoTest.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::SoTest;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use Hydra::Helper::CatalystUtils;
 use HTTP::Request;

src/lib/Hydra/Plugin/SubversionInput.pm

@@ -1,6 +1,7 @@
 package Hydra::Plugin::SubversionInput;
 
 use strict;
+use warnings;
 use parent 'Hydra::Plugin';
 use Digest::SHA qw(sha256_hex);
 use Hydra::Helper::Nix;

src/lib/Hydra/View/JSON.pm

@@ -1,3 +1,5 @@
 package Hydra::View::JSON;
+use strict;
+use warnings;
 use base qw(Catalyst::View::JSON);
 1;

src/lib/Hydra/View/NARInfo.pm

@@ -1,5 +1,7 @@
 package Hydra::View::NARInfo;
 
+use strict;
+use warnings;
 use File::Basename;
 use Hydra::Helper::CatalystUtils;
 use MIME::Base64;
@@ -7,7 +9,6 @@ use Nix::Manifest;
 use Nix::Store;
 use Nix::Utils;
 use base qw/Catalyst::View/;
-use strict;
 
 sub process {
     my ($self, $c) = @_;

src/lib/Hydra/View/NixClosure.pm

@@ -1,6 +1,7 @@
 package Hydra::View::NixClosure;
 
 use strict;
+use warnings;
 use base qw/Catalyst::View/;
 use IO::Pipe;
 

src/lib/Hydra/View/NixExprs.pm

@@ -1,6 +1,7 @@
 package Hydra::View::NixExprs;
 
 use strict;
+use warnings;
 use base qw/Catalyst::View/;
 use Hydra::Helper::Nix;
 use Hydra::Helper::Escape;

src/lib/Hydra/View/NixLog.pm

@@ -1,6 +1,7 @@
 package Hydra::View::NixLog;
 
 use strict;
+use warnings;
 use base qw/Catalyst::View/;
 use Hydra::Helper::CatalystUtils;
 

src/lib/Hydra/View/NixManifest.pm

@@ -1,6 +1,7 @@
 package Hydra::View::NixManifest;
 
 use strict;
+use warnings;
 use base qw/Catalyst::View/;
 use Hydra::Helper::Nix;
 use Nix::Store;

src/lib/Hydra/View/NixNAR.pm

@@ -1,6 +1,7 @@
 package Hydra::View::NixNAR;
 
 use strict;
+use warnings;
 use base qw/Catalyst::View/;
 use Hydra::Helper::CatalystUtils;
 

src/lib/Hydra/View/TT.pm

@@ -1,6 +1,7 @@
 package Hydra::View::TT;
 
 use strict;
+use warnings;
 use base 'Catalyst::View::TT';
 use Hydra::Helper::Nix;
 use Time::Seconds;

src/script/hydra-backfill-ids

@@ -1,6 +1,7 @@
 #! /usr/bin/env perl
 
 use strict;
+use warnings;
 use utf8;
 use Hydra::Model::DB;
 

src/script/hydra-create-user

@@ -1,6 +1,7 @@
 #! /usr/bin/env perl
 
 use strict;
+use warnings;
 use Hydra::Schema;
 use Hydra::Helper::Nix;
 use Hydra::Model::DB;

src/script/hydra-dev-server

@@ -1,5 +1,8 @@
 #! /usr/bin/env perl
 
+use strict;
+use warnings;
+
 BEGIN {
     $ENV{CATALYST_SCRIPT_GEN} = 40;
 }

src/script/hydra-eval-jobset

@@ -1,6 +1,7 @@
 #! /usr/bin/env perl
 
 use strict;
+use warnings;
 use utf8;
 use Config::General;
 use Data::Dump qw(dump);

src/script/hydra-init

@@ -1,6 +1,7 @@
 #! /usr/bin/env perl
 
 use strict;
+use warnings;
 use Hydra::Schema;
 use Hydra::Helper::Nix;
 use Hydra::Model::DB;

src/script/hydra-notify

@@ -1,6 +1,7 @@
 #! /usr/bin/env perl
 
 use strict;
+use warnings;
 use utf8;
 use Getopt::Long;
 use HTTP::Server::PSGI;

src/script/hydra-s3-backup-collect-garbage

@@ -1,6 +1,7 @@
 #! /usr/bin/env perl
 
 use strict;
+use warnings;
 use File::Basename;
 use Fcntl;
 use IO::File;

src/script/hydra-send-stats

@@ -1,6 +1,7 @@
 #! /usr/bin/env perl
 
 use strict;
+use warnings;
 use utf8;
 use Hydra::Helper::Nix;
 use Net::Statsd;

src/script/hydra-server

@@ -1,5 +1,8 @@
 #! /usr/bin/env perl
 
+use strict;
+use warnings;
+
 BEGIN {
     $ENV{CATALYST_SCRIPT_GEN} = 40;
 }

src/script/hydra-update-gc-roots

@@ -1,6 +1,7 @@
 #! /usr/bin/env perl
 
 use strict;
+use warnings;
 use File::Path;
 use File::stat;
 use File::Basename;

src/sql/update-dbix.pl

@@ -1,4 +1,6 @@
 use Cwd;
+use strict;
+use warnings;
 
 die "$0: dbi connection string required \n" if scalar @ARGV != 1;
 

t/Config/hydra-notify.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init(hydra_config => q|

t/Config/include.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init(

t/Config/statsd.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init(hydra_config => q|

t/Controller/Build/evals.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use Data::Dumper;
 my %ctx = test_init();

t/Controller/Jobset/channel.t

@@ -1,5 +1,6 @@
 use feature 'unicode_strings';
 use strict;
+use warnings;
 use Setup;
 use IO::Uncompress::Bunzip2 qw(bunzip2);
 use Archive::Tar;

t/Controller/Jobset/evals.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use Data::Dumper;
 my %ctx = test_init();

t/Controller/Jobset/http.t

@@ -1,5 +1,6 @@
 use feature 'unicode_strings';
 use strict;
+use warnings;
 use Setup;
 use JSON qw(decode_json encode_json);
 

t/Controller/Jobset/type-constraints.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 my %ctx = test_init();
 

t/Controller/Root/evals.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use Data::Dumper;
 my %ctx = test_init();

t/Controller/metrics.t

@@ -1,5 +1,6 @@
 use feature 'unicode_strings';
 use strict;
+use warnings;
 use Setup;
 use JSON qw(decode_json encode_json);
 

t/Controller/projects.t

@@ -1,5 +1,6 @@
 use feature 'unicode_strings';
 use strict;
+use warnings;
 use Setup;
 use JSON qw(decode_json encode_json);
 

t/Event.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Hydra::Event;
 
 use Test2::V0;

t/Event/BuildFinished.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init();

t/Event/BuildStarted.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init();

t/Event/StepFinished.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init();

t/Helper/escape.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use Data::Dumper;
 use Test2::V0;

t/PostgresListener.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init();

t/Schema/Users.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init();

t/api-test.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use JSON;
 use File::Copy;

t/build-products.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init();

t/evaluate-basic.t

@@ -1,5 +1,6 @@
 use feature 'unicode_strings';
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init();

t/evaluate-dependent-jobsets.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init();

t/input-types/bzr-checkout.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use TestScmInput;
 

t/input-types/bzr.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use TestScmInput;
 

t/input-types/darcs.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use TestScmInput;
 

t/input-types/deepgit.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use TestScmInput;
 

t/input-types/git-rev.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use TestScmInput;
 

t/input-types/git.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use TestScmInput;
 

t/input-types/hg.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use TestScmInput;
 

t/input-types/svn-checkout.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use TestScmInput;
 

t/input-types/svn.t

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use Setup;
 use TestScmInput;
 

t/lib/Setup.pm

@@ -1,6 +1,7 @@
 package Setup;
 
 use strict;
+use warnings;
 use Exporter;
 use Test::PostgreSQL;
 use File::Temp;

t/queue-runner/default-machine-file.t

@@ -1,5 +1,6 @@
 use feature 'unicode_strings';
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init(

t/s3-backup-test.pl

@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use File::Basename;
 use Hydra::Model::DB;
 use Hydra::Helper::Nix;

t/scripts/hydra-create-user.t

@@ -1,5 +1,6 @@
 use feature 'unicode_strings';
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init();

t/scripts/hydra-init.t

@@ -1,5 +1,6 @@
 use feature 'unicode_strings';
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init();

t/scripts/hydra-send-stats.t

@@ -1,5 +1,6 @@
 use feature 'unicode_strings';
 use strict;
+use warnings;
 use Setup;
 
 my %ctx = test_init();

t/setup-notifications-jobset.pl

@@ -1,3 +1,5 @@
+use strict;
+use warnings;
 use LWP::UserAgent;
 use JSON;