delroth/hydra
0
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

hydra-queue-runner: move exporter back to State::run

Browse source 
It's (arguably) better than risking pinning the thread at 100% due to
the busy `while` loop.
This commit is contained in:
Cole Helbling 2022-04-06 10:46:56 -07:00
parent 8c5636fe18
commit 33bc60b83c
1 changed files with 11 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
src/hydra-queue-runner/hydra-queue-runner.cc
View file

@ -750,24 +750,6 @@ void State::unlock()
}
void State::runMetricsExporter()
{
std::cout << "Starting the Prometheus exporter on port " << metricsPort << std::endl;
/* Set up simple exporter, to show that we're still alive. */
std::string metricsAddress{"127.0.0.1"};
prometheus::Exposer exposer{metricsAddress + ":" + std::to_string(metricsPort)};
auto exposerPort = exposer.GetListeningPorts().front();
exposer.RegisterCollectable(registry);
std::cout << "Started the Prometheus exporter, listening on "
<< "http://" << metricsAddress << ":" << exposerPort << "/metrics"
<< std::endl;
while (true) {};
}
void State::run(BuildID buildOne)
{
/* Can't be bothered to shut down cleanly. Goodbye! */
@ -780,7 +762,17 @@ void State::run(BuildID buildOne)
if (!lock)
throw Error("hydra-queue-runner is already running");
std::thread(&State::runMetricsExporter, this).detach();
std::cout << "Starting the Prometheus exporter on port " << metricsPort << std::endl;
/* Set up simple exporter, to show that we're still alive. */
std::string metricsAddress{"127.0.0.1"}; // FIXME: configurable
prometheus::Exposer promExposer{metricsAddress + ":" + std::to_string(metricsPort)};
auto exposerPort = promExposer.GetListeningPorts().front();
promExposer.RegisterCollectable(registry);
std::cout << "Started the Prometheus exporter, listening on "
<< "http://" << metricsAddress << ":" << exposerPort << "/metrics"
<< std::endl;
Store::Params localParams;
localParams["max-connections"] = "16";