Graham Christensen
0d08106b49
Merge pull request #302 from LnL7/test-nixos-nixpkgs-arg
...
nix: pass '--arg nixpkgs' for nixos and generalize argument handling
2019-01-14 19:12:49 -05:00
Daiderd Jordan
69263d7fa6
nix: cleanup and fix warnings
2019-01-15 00:42:07 +01:00
Daiderd Jordan
6f5f58e2a1
nix: pass '--arg nixpkgs' for nixos and generalize argument handling
...
This makes sure nixpkgs isn't passed in using fetchGit or filterSource,
which isn't allowed to be imported with restricted eval. And avoids
of of the duplication between safely_instantiate_attrs_cmd and
safely_build_attrs_cmd making that easier to test.
2019-01-14 23:34:46 +01:00
Roman Volosatovs
8edbaf82a9
Add rvolosatovs to extra-known-users
2019-01-08 11:39:54 +01:00
Graham Christensen
d1976841c3
Merge pull request #296 from NixOS/request-maintainers
...
Request maintainers
2019-01-03 12:25:46 -05:00
Graham Christensen
b788084512
Send review requests
2019-01-03 11:58:37 -05:00
Graham Christensen
9dbb1c4b94
Upgrade crates, including hubcaps for review requests
2019-01-03 11:58:22 -05:00
Graham Christensen
6912713eb5
Merge pull request #293 from NixOS/experiment/maintainer-ping
...
Experiment/maintainer ping
2019-01-03 08:24:28 -05:00
Graham Christensen
5c04e88375
Fixup formatting
2019-01-02 22:26:58 -05:00
Graham Christensen
07a5a145a1
Remove 'pkgs.' prefix from each packge
2019-01-02 22:16:50 -05:00
Graham Christensen
30372bbd39
Delete beta maintainer script
2019-01-02 22:16:07 -05:00
Graham Christensen
9ba201d71d
Support passing more authorized paths to the safe evaluator
2019-01-02 22:16:05 -05:00
Graham Christensen
65bec865c5
Make a gist with potential maintainers
2019-01-02 22:05:45 -05:00
Graham Christensen
c058b261e2
Make the maintainer API public
2019-01-02 22:01:50 -05:00
Graham Christensen
810cdbe4c4
Use nice errors
2019-01-02 22:00:40 -05:00
Graham Christensen
293ca1f9a6
Extract calculate to its own fuction
2019-01-02 21:58:52 -05:00
Graham Christensen
31f4ec74b4
Move themaintainer test to be self-contained with a healthy ccopy of the nixpkgs lib
2019-01-02 21:57:06 -05:00
Graham Christensen
5b6a387fee
Calculate maintainers
2019-01-02 21:53:50 -05:00
Graham Christensen
789e0d81bd
Update the maintainers script for clarity on how to call it
2019-01-02 21:52:41 -05:00
Graham Christensen
a7de0792fc
nix: teach it to evaluate strings passed over the cli
2019-01-02 21:52:41 -05:00
Graham Christensen
8333409bd0
This nightmare compares files changed, attrs changed, and pings maintainers
2019-01-02 21:49:24 -05:00
Graham Christensen
040c33717c
Merge pull request #290 from hedning/trust-hedning
...
Move @hedning to trusted users
2019-01-02 21:48:48 -05:00
Graham Christensen
fc5d158b02
Merge pull request #292 from worldofpeace/trust-worldofpeace
...
Move @worldofpeace to trusted users
2019-01-02 21:48:41 -05:00
Graham Christensen
11d9fcf348
Merge pull request #294 from puffnfresh/patch-1
...
Add puffnfresh to trusted users
2019-01-02 21:48:29 -05:00
Graham Christensen
830f376699
Merge pull request #295 from NixOS/clippy
...
Clippy and cargo fmt
2019-01-02 21:48:14 -05:00
Graham Christensen
f6192a7f35
move pedantry up, set -x
2019-01-02 21:29:01 -05:00
Graham Christensen
434f4dc5bb
fixup: box the buildresult in finish
2019-01-02 21:13:03 -05:00
Graham Christensen
41105c1862
fixup formatting
2019-01-02 21:05:51 -05:00
Graham Christensen
053ea863e0
clippy: Action::Publish(QueueMsg box contenst
2019-01-02 21:05:27 -05:00
Graham Christensen
63fcd856da
Box MsgType::Finish(BuildResult)
2019-01-02 20:58:05 -05:00
Graham Christensen
d49bd4495a
Clippy: nix: borrow the op
2019-01-02 20:56:40 -05:00
Graham Christensen
f2030c2ee5
Extra nl
2019-01-02 20:52:45 -05:00
Graham Christensen
64dafe5e82
clippy: unneeded borrow
2019-01-02 20:47:29 -05:00
Graham Christensen
8122e01b1d
clippy: Implement defaults
2019-01-02 20:43:35 -05:00
Graham Christensen
671a9257c9
Check clippy and fmt in travis
2019-01-02 20:18:42 -05:00
Graham Christensen
87974028d1
build phase for rust pedantry
2019-01-02 20:06:50 -05:00
Graham Christensen
164e2ccbe2
cargo fmt
2019-01-02 20:01:16 -05:00
Graham Christensen
1d906ff67c
clippy: write -> write_all
2019-01-02 19:45:23 -05:00
Graham Christensen
c73cf2e328
clippy: Unneeded lifetime
2019-01-02 19:45:23 -05:00
Graham Christensen
e9f437d49f
clippy: drop &ref
2019-01-02 19:45:23 -05:00
Graham Christensen
91e23d101e
clippy: identical conversion
2019-01-02 19:45:23 -05:00
Graham Christensen
f2a0ca259e
clippy: as_bytes on string literals
2019-01-02 19:45:23 -05:00
Graham Christensen
2b338c3549
clippy: if _ then _ ... is an expression
2019-01-02 19:45:17 -05:00
Graham Christensen
8fe689989a
clippy: don't clone a copy
2019-01-02 19:43:58 -05:00
Graham Christensen
2a908134ac
clippy: single-character string constant used as pattern
2019-01-02 19:43:58 -05:00
Graham Christensen
fc8494b45f
clippy: unwrap_or/ok_or(function call) unwrap_or_else/ok_or_else
2019-01-02 19:43:40 -05:00
Graham Christensen
0ab2ce45cf
clippy: map .clone -> cloned
2019-01-02 19:43:40 -05:00
Graham Christensen
a9e2c02c8c
Clippy: redundant pattern matching, consider using is_err
2019-01-02 19:43:23 -05:00
Graham Christensen
48d2815c1a
clippy: useless use of vec[]
2019-01-02 19:43:23 -05:00
Graham Christensen
99159dd74e
Clippy: comparisons of array len to 0
2019-01-02 19:43:22 -05:00