danderson/ofborg
0
0
Fork 0
forked from the-distro/ofborg
Code Pull requests Activity

add basic structured logging to comment poster

Browse source
This commit is contained in:
Daiderd Jordan 2020-05-14 20:27:59 +02:00
parent 2b59f86125
commit cb9a125cdc
No known key found for this signature in database
GPG key ID: D02435D05B810C96
2 changed files with 22 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
ofborg/src/message/buildresult.rs
View file

@ -133,6 +133,13 @@ impl BuildResult {
} }
} }
pub fn pr(&self) -> Pr {
match self {
BuildResult::Legacy { pr, .. } => pr.to_owned(),
BuildResult::V1 { pr, .. } => pr.to_owned(),
}
}
pub fn status(&self) -> BuildStatus { pub fn status(&self) -> BuildStatus {
match *self { match *self {
BuildResult::Legacy { BuildResult::Legacy {

19
ofborg/src/tasks/githubcommentposter.rs
View file

@ -6,7 +6,7 @@ use crate::worker;
use chrono::{DateTime, Utc}; use chrono::{DateTime, Utc};
use hubcaps::checks::{CheckRunOptions, CheckRunState, Conclusion, Output}; use hubcaps::checks::{CheckRunOptions, CheckRunState, Conclusion, Output};
use tracing::info; use tracing::{debug, debug_span, info};
pub struct GitHubCommentPoster { pub struct GitHubCommentPoster {
github_vend: GithubAppVendingMachine, github_vend: GithubAppVendingMachine,
@ -50,22 +50,33 @@ impl worker::SimpleWorker for GitHubCommentPoster {
let mut checks: Vec<CheckRunOptions> = vec![]; let mut checks: Vec<CheckRunOptions> = vec![];
let repo: Repo; let repo: Repo;
match job { let pr = match job {
PostableEvent::BuildQueued(queued_job) => { PostableEvent::BuildQueued(queued_job) => {
repo = queued_job.job.repo.clone(); repo = queued_job.job.repo.clone();
for architecture in queued_job.architectures.iter() { for architecture in queued_job.architectures.iter() {
checks.push(job_to_check(&queued_job.job, &architecture, Utc::now())); checks.push(job_to_check(&queued_job.job, &architecture, Utc::now()));
} }
queued_job.job.pr.to_owned()
} }
PostableEvent::BuildFinished(finished_job) => { PostableEvent::BuildFinished(finished_job) => {
let result = finished_job.legacy(); let result = finished_job.legacy();
repo = result.repo.clone(); repo = result.repo.clone();
checks.push(result_to_check(&result, Utc::now())); checks.push(result_to_check(&result, Utc::now()));
finished_job.pr()
} }
} };
let span = debug_span!("job", pr = ?pr.number);
let _enter = span.enter();
for check in checks { for check in checks {
info!(":{:?}", check); info!(
"check {:?} {} {}",
check.status,
check.name,
check.details_url.as_ref().unwrap_or(&String::from("-"))
);
debug!("{:?}", check);
let check_create_attempt = self let check_create_attempt = self
.github_vend .github_vend