From d35a5c9b0af9086d66c9eddf12aef0e7d01e9856 Mon Sep 17 00:00:00 2001
From: Graham Christensen <graham@grahamc.com>
Date: Tue, 29 Jan 2019 20:38:54 -0500
Subject: [PATCH 1/4] Add tests for the package arch change tagger

---
 ofborg/src/tagger.rs | 236 ++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 235 insertions(+), 1 deletion(-)

diff --git a/ofborg/src/tagger.rs b/ofborg/src/tagger.rs
index 3d3bc81..eadd707 100644
--- a/ofborg/src/tagger.rs
+++ b/ofborg/src/tagger.rs
@@ -164,8 +164,8 @@ impl RebuildTagger {
         }
 
         self.selected = vec![
-            format!("10.rebuild-linux: {}", self.bucket(counter_linux)),
             format!("10.rebuild-darwin: {}", self.bucket(counter_darwin)),
+            format!("10.rebuild-linux: {}", self.bucket(counter_linux)),
         ];
 
         for tag in &self.selected {
@@ -189,6 +189,8 @@ impl RebuildTagger {
             remove.remove(pos);
         }
 
+        remove.sort();
+
         remove
     }
 
@@ -307,6 +309,238 @@ impl MaintainerPRTagger {
 mod tests {
     use super::*;
 
+    struct PackageArchSrc {
+        linux: usize,
+        darwin: usize,
+    }
+
+    impl PackageArchSrc {
+        pub fn linux(linux: usize) -> PackageArchSrc {
+            PackageArchSrc { linux, darwin: 0 }
+        }
+
+        pub fn darwin(darwin: usize) -> PackageArchSrc {
+            PackageArchSrc::linux(0).and_darwin(darwin)
+        }
+
+        pub fn and_linux(mut self, linux: usize) -> PackageArchSrc {
+            self.linux = linux;
+            self
+        }
+
+        pub fn and_darwin(mut self, darwin: usize) -> PackageArchSrc {
+            self.darwin = darwin;
+            self
+        }
+    }
+
+    impl From<PackageArchSrc> for Vec<PackageArch> {
+        fn from(src: PackageArchSrc) -> Vec<PackageArch> {
+            let mut darwin: Vec<PackageArch> = (0..src.darwin)
+                .into_iter()
+                .map(|_| PackageArch {
+                    package: String::from("bogus :)"),
+                    architecture: String::from("x86_64-darwin"),
+                })
+                .collect();
+            let linux: Vec<PackageArch> = (0..src.linux)
+                .into_iter()
+                .map(|_| PackageArch {
+                    package: String::from("bogus :)"),
+                    architecture: String::from("x86_64-linux"),
+                })
+                .collect();
+
+            let mut combined = darwin;
+            combined.extend(linux);
+            combined
+        }
+    }
+
+    #[test]
+    pub fn test_packages_changed() {
+        let mut tagger = RebuildTagger::new();
+        tagger.parse_attrs(PackageArchSrc::linux(0).and_darwin(0).into());
+        assert_eq!(
+            tagger.tags_to_add(),
+            vec!["10.rebuild-darwin: 0", "10.rebuild-linux: 0",]
+        );
+        assert_eq!(
+            tagger.tags_to_remove(),
+            vec![
+                "10.rebuild-darwin: 1-10",
+                "10.rebuild-darwin: 101-500",
+                "10.rebuild-darwin: 11-100",
+                "10.rebuild-darwin: 501+",
+                "10.rebuild-linux: 1-10",
+                "10.rebuild-linux: 101-500",
+                "10.rebuild-linux: 11-100",
+                "10.rebuild-linux: 501+"
+            ]
+        );
+
+        let mut tagger = RebuildTagger::new();
+        tagger.parse_attrs(PackageArchSrc::linux(1).into());
+
+        assert_eq!(
+            tagger.tags_to_add(),
+            vec!["10.rebuild-darwin: 0", "10.rebuild-linux: 1-10",]
+        );
+        assert_eq!(
+            tagger.tags_to_remove(),
+            vec![
+                "10.rebuild-darwin: 1-10",
+                "10.rebuild-darwin: 101-500",
+                "10.rebuild-darwin: 11-100",
+                "10.rebuild-darwin: 501+",
+                "10.rebuild-linux: 0",
+                "10.rebuild-linux: 101-500",
+                "10.rebuild-linux: 11-100",
+                "10.rebuild-linux: 501+"
+            ]
+        );
+
+        let mut tagger = RebuildTagger::new();
+        tagger.parse_attrs(PackageArchSrc::linux(1).and_darwin(1).into());
+        assert_eq!(
+            tagger.tags_to_add(),
+            vec!["10.rebuild-darwin: 1-10", "10.rebuild-linux: 1-10",]
+        );
+        assert_eq!(
+            tagger.tags_to_remove(),
+            vec![
+                "10.rebuild-darwin: 0",
+                "10.rebuild-darwin: 101-500",
+                "10.rebuild-darwin: 11-100",
+                "10.rebuild-darwin: 501+",
+                "10.rebuild-linux: 0",
+                "10.rebuild-linux: 101-500",
+                "10.rebuild-linux: 11-100",
+                "10.rebuild-linux: 501+"
+            ]
+        );
+
+        let mut tagger = RebuildTagger::new();
+        tagger.parse_attrs(PackageArchSrc::linux(10).and_darwin(10).into());
+        assert_eq!(
+            tagger.tags_to_add(),
+            vec!["10.rebuild-darwin: 1-10", "10.rebuild-linux: 1-10",]
+        );
+        assert_eq!(
+            tagger.tags_to_remove(),
+            vec![
+                "10.rebuild-darwin: 0",
+                "10.rebuild-darwin: 101-500",
+                "10.rebuild-darwin: 11-100",
+                "10.rebuild-darwin: 501+",
+                "10.rebuild-linux: 0",
+                "10.rebuild-linux: 101-500",
+                "10.rebuild-linux: 11-100",
+                "10.rebuild-linux: 501+"
+            ]
+        );
+
+        let mut tagger = RebuildTagger::new();
+        tagger.parse_attrs(PackageArchSrc::linux(11).and_darwin(11).into());
+        assert_eq!(
+            tagger.tags_to_add(),
+            vec!["10.rebuild-darwin: 11-100", "10.rebuild-linux: 11-100",]
+        );
+        assert_eq!(
+            tagger.tags_to_remove(),
+            vec![
+                "10.rebuild-darwin: 0",
+                "10.rebuild-darwin: 1-10",
+                "10.rebuild-darwin: 101-500",
+                "10.rebuild-darwin: 501+",
+                "10.rebuild-linux: 0",
+                "10.rebuild-linux: 1-10",
+                "10.rebuild-linux: 101-500",
+                "10.rebuild-linux: 501+"
+            ]
+        );
+
+        let mut tagger = RebuildTagger::new();
+        tagger.parse_attrs(PackageArchSrc::linux(100).and_darwin(100).into());
+        assert_eq!(
+            tagger.tags_to_add(),
+            vec!["10.rebuild-darwin: 11-100", "10.rebuild-linux: 11-100",]
+        );
+        assert_eq!(
+            tagger.tags_to_remove(),
+            vec![
+                "10.rebuild-darwin: 0",
+                "10.rebuild-darwin: 1-10",
+                "10.rebuild-darwin: 101-500",
+                "10.rebuild-darwin: 501+",
+                "10.rebuild-linux: 0",
+                "10.rebuild-linux: 1-10",
+                "10.rebuild-linux: 101-500",
+                "10.rebuild-linux: 501+"
+            ]
+        );
+
+        let mut tagger = RebuildTagger::new();
+        tagger.parse_attrs(PackageArchSrc::linux(101).and_darwin(101).into());
+        assert_eq!(
+            tagger.tags_to_add(),
+            vec!["10.rebuild-darwin: 101-500", "10.rebuild-linux: 101-500",]
+        );
+        assert_eq!(
+            tagger.tags_to_remove(),
+            vec![
+                "10.rebuild-darwin: 0",
+                "10.rebuild-darwin: 1-10",
+                "10.rebuild-darwin: 11-100",
+                "10.rebuild-darwin: 501+",
+                "10.rebuild-linux: 0",
+                "10.rebuild-linux: 1-10",
+                "10.rebuild-linux: 11-100",
+                "10.rebuild-linux: 501+"
+            ]
+        );
+
+        let mut tagger = RebuildTagger::new();
+        tagger.parse_attrs(PackageArchSrc::linux(500).and_darwin(500).into());
+        assert_eq!(
+            tagger.tags_to_add(),
+            vec!["10.rebuild-darwin: 101-500", "10.rebuild-linux: 101-500",]
+        );
+        assert_eq!(
+            tagger.tags_to_remove(),
+            vec![
+                "10.rebuild-darwin: 0",
+                "10.rebuild-darwin: 1-10",
+                "10.rebuild-darwin: 11-100",
+                "10.rebuild-darwin: 501+",
+                "10.rebuild-linux: 0",
+                "10.rebuild-linux: 1-10",
+                "10.rebuild-linux: 11-100",
+                "10.rebuild-linux: 501+"
+            ]
+        );
+
+        let mut tagger = RebuildTagger::new();
+        tagger.parse_attrs(PackageArchSrc::linux(501).and_darwin(501).into());
+        assert_eq!(
+            tagger.tags_to_add(),
+            vec!["10.rebuild-darwin: 501+", "10.rebuild-linux: 501+"]
+        );
+        assert_eq!(
+            tagger.tags_to_remove(),
+            vec![
+                "10.rebuild-darwin: 0",
+                "10.rebuild-darwin: 1-10",
+                "10.rebuild-darwin: 101-500",
+                "10.rebuild-darwin: 11-100",
+                "10.rebuild-linux: 0",
+                "10.rebuild-linux: 1-10",
+                "10.rebuild-linux: 101-500",
+                "10.rebuild-linux: 11-100",
+            ]
+        );
+    }
+
     #[test]
     pub fn test_files_changed_list() {
         let mut criteria: HashMap<String, Vec<String>> = HashMap::new();

From d0bc3b067123d6d33675c0839beb8769af40f3e6 Mon Sep 17 00:00:00 2001
From: Graham Christensen <graham@grahamc.com>
Date: Tue, 29 Jan 2019 21:42:19 -0500
Subject: [PATCH 2/4] tests: don't sort so test tags are ordered nicely

---
 ofborg/src/tagger.rs | 63 ++++++++++++++++++++++----------------------
 1 file changed, 31 insertions(+), 32 deletions(-)

diff --git a/ofborg/src/tagger.rs b/ofborg/src/tagger.rs
index eadd707..fd84c4d 100644
--- a/ofborg/src/tagger.rs
+++ b/ofborg/src/tagger.rs
@@ -119,20 +119,19 @@ impl Default for RebuildTagger {
     fn default() -> RebuildTagger {
         let mut t = RebuildTagger {
             possible: vec![
-                String::from("10.rebuild-linux: 501+"),
-                String::from("10.rebuild-linux: 101-500"),
-                String::from("10.rebuild-linux: 11-100"),
-                String::from("10.rebuild-linux: 1-10"),
-                String::from("10.rebuild-linux: 0"),
-                String::from("10.rebuild-darwin: 501+"),
-                String::from("10.rebuild-darwin: 101-500"),
-                String::from("10.rebuild-darwin: 11-100"),
-                String::from("10.rebuild-darwin: 1-10"),
                 String::from("10.rebuild-darwin: 0"),
+                String::from("10.rebuild-darwin: 1-10"),
+                String::from("10.rebuild-darwin: 11-100"),
+                String::from("10.rebuild-darwin: 101-500"),
+                String::from("10.rebuild-darwin: 501+"),
+                String::from("10.rebuild-linux: 0"),
+                String::from("10.rebuild-linux: 1-10"),
+                String::from("10.rebuild-linux: 11-100"),
+                String::from("10.rebuild-linux: 101-500"),
+                String::from("10.rebuild-linux: 501+"),
             ],
             selected: vec![],
         };
-        t.possible.sort();
 
         t
     }
@@ -183,13 +182,13 @@ impl RebuildTagger {
     }
 
     pub fn tags_to_remove(&self) -> Vec<String> {
-        let mut remove = self.possible.clone();
-        for tag in &self.selected {
-            let pos = remove.binary_search(&tag).unwrap();
-            remove.remove(pos);
-        }
+        let mut remove = vec![];
 
-        remove.sort();
+        for tag in self.possible.clone().into_iter() {
+            if !self.selected.contains(&tag) {
+                remove.push(tag);
+            }
+        }
 
         remove
     }
@@ -369,13 +368,13 @@ mod tests {
             tagger.tags_to_remove(),
             vec![
                 "10.rebuild-darwin: 1-10",
-                "10.rebuild-darwin: 101-500",
                 "10.rebuild-darwin: 11-100",
+                "10.rebuild-darwin: 101-500",
                 "10.rebuild-darwin: 501+",
                 "10.rebuild-linux: 1-10",
-                "10.rebuild-linux: 101-500",
                 "10.rebuild-linux: 11-100",
-                "10.rebuild-linux: 501+"
+                "10.rebuild-linux: 101-500",
+                "10.rebuild-linux: 501+",
             ]
         );
 
@@ -390,13 +389,13 @@ mod tests {
             tagger.tags_to_remove(),
             vec![
                 "10.rebuild-darwin: 1-10",
-                "10.rebuild-darwin: 101-500",
                 "10.rebuild-darwin: 11-100",
+                "10.rebuild-darwin: 101-500",
                 "10.rebuild-darwin: 501+",
                 "10.rebuild-linux: 0",
-                "10.rebuild-linux: 101-500",
                 "10.rebuild-linux: 11-100",
-                "10.rebuild-linux: 501+"
+                "10.rebuild-linux: 101-500",
+                "10.rebuild-linux: 501+",
             ]
         );
 
@@ -410,13 +409,13 @@ mod tests {
             tagger.tags_to_remove(),
             vec![
                 "10.rebuild-darwin: 0",
-                "10.rebuild-darwin: 101-500",
                 "10.rebuild-darwin: 11-100",
+                "10.rebuild-darwin: 101-500",
                 "10.rebuild-darwin: 501+",
                 "10.rebuild-linux: 0",
-                "10.rebuild-linux: 101-500",
                 "10.rebuild-linux: 11-100",
-                "10.rebuild-linux: 501+"
+                "10.rebuild-linux: 101-500",
+                "10.rebuild-linux: 501+",
             ]
         );
 
@@ -430,13 +429,13 @@ mod tests {
             tagger.tags_to_remove(),
             vec![
                 "10.rebuild-darwin: 0",
-                "10.rebuild-darwin: 101-500",
                 "10.rebuild-darwin: 11-100",
+                "10.rebuild-darwin: 101-500",
                 "10.rebuild-darwin: 501+",
                 "10.rebuild-linux: 0",
-                "10.rebuild-linux: 101-500",
                 "10.rebuild-linux: 11-100",
-                "10.rebuild-linux: 501+"
+                "10.rebuild-linux: 101-500",
+                "10.rebuild-linux: 501+",
             ]
         );
 
@@ -456,7 +455,7 @@ mod tests {
                 "10.rebuild-linux: 0",
                 "10.rebuild-linux: 1-10",
                 "10.rebuild-linux: 101-500",
-                "10.rebuild-linux: 501+"
+                "10.rebuild-linux: 501+",
             ]
         );
 
@@ -476,7 +475,7 @@ mod tests {
                 "10.rebuild-linux: 0",
                 "10.rebuild-linux: 1-10",
                 "10.rebuild-linux: 101-500",
-                "10.rebuild-linux: 501+"
+                "10.rebuild-linux: 501+",
             ]
         );
 
@@ -496,7 +495,7 @@ mod tests {
                 "10.rebuild-linux: 0",
                 "10.rebuild-linux: 1-10",
                 "10.rebuild-linux: 11-100",
-                "10.rebuild-linux: 501+"
+                "10.rebuild-linux: 501+",
             ]
         );
 
@@ -516,7 +515,7 @@ mod tests {
                 "10.rebuild-linux: 0",
                 "10.rebuild-linux: 1-10",
                 "10.rebuild-linux: 11-100",
-                "10.rebuild-linux: 501+"
+                "10.rebuild-linux: 501+",
             ]
         );
 

From 99cc0ce3941fe6071d9e661c2151214529332ce5 Mon Sep 17 00:00:00 2001
From: Graham Christensen <graham@grahamc.com>
Date: Tue, 29 Jan 2019 21:42:44 -0500
Subject: [PATCH 3/4] Support bigger ranges

---
 ofborg/src/tagger.rs | 313 +++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 299 insertions(+), 14 deletions(-)

diff --git a/ofborg/src/tagger.rs b/ofborg/src/tagger.rs
index fd84c4d..7539942 100644
--- a/ofborg/src/tagger.rs
+++ b/ofborg/src/tagger.rs
@@ -124,11 +124,19 @@ impl Default for RebuildTagger {
                 String::from("10.rebuild-darwin: 11-100"),
                 String::from("10.rebuild-darwin: 101-500"),
                 String::from("10.rebuild-darwin: 501+"),
+                String::from("10.rebuild-darwin: 501-1,000"),
+                String::from("10.rebuild-darwin: 1,001-2,500"),
+                String::from("10.rebuild-darwin: 2,501-5,000"),
+                String::from("10.rebuild-darwin: 5,001+"),
                 String::from("10.rebuild-linux: 0"),
                 String::from("10.rebuild-linux: 1-10"),
                 String::from("10.rebuild-linux: 11-100"),
                 String::from("10.rebuild-linux: 101-500"),
                 String::from("10.rebuild-linux: 501+"),
+                String::from("10.rebuild-linux: 501-1,000"),
+                String::from("10.rebuild-linux: 1,001-2,500"),
+                String::from("10.rebuild-linux: 2,501-5,000"),
+                String::from("10.rebuild-linux: 5,001+"),
             ],
             selected: vec![],
         };
@@ -162,10 +170,20 @@ impl RebuildTagger {
             }
         }
 
-        self.selected = vec![
-            format!("10.rebuild-darwin: {}", self.bucket(counter_darwin)),
-            format!("10.rebuild-linux: {}", self.bucket(counter_linux)),
-        ];
+        self.selected = vec![];
+        self.selected.extend(
+            RebuildTagger::bucket(counter_darwin)
+                .iter()
+                .map(|bucket| format!("10.rebuild-darwin: {}", bucket))
+                .collect::<Vec<String>>(),
+        );
+
+        self.selected.extend(
+            RebuildTagger::bucket(counter_linux)
+                .iter()
+                .map(|bucket| format!("10.rebuild-linux: {}", bucket))
+                .collect::<Vec<String>>(),
+        );
 
         for tag in &self.selected {
             if !self.possible.contains(&tag) {
@@ -193,17 +211,23 @@ impl RebuildTagger {
         remove
     }
 
-    fn bucket(&self, count: u64) -> &str {
-        if count > 500 {
-            "501+"
+    fn bucket(count: u64) -> &'static [&'static str] {
+        if count > 5000 {
+            &["501+", "5,001+"]
+        } else if count > 2500 {
+            &["501+", "2,501-5,000"]
+        } else if count > 1000 {
+            &["501+", "1,001-2,500"]
+        } else if count > 500 {
+            &["501+", "501-1,000"]
         } else if count > 100 {
-            "101-500"
+            &["101-500"]
         } else if count > 10 {
-            "11-100"
+            &["11-100"]
         } else if count > 0 {
-            "1-10"
+            &["1-10"]
         } else {
-            "0"
+            &["0"]
         }
     }
 }
@@ -371,10 +395,18 @@ mod tests {
                 "10.rebuild-darwin: 11-100",
                 "10.rebuild-darwin: 101-500",
                 "10.rebuild-darwin: 501+",
+                "10.rebuild-darwin: 501-1,000",
+                "10.rebuild-darwin: 1,001-2,500",
+                "10.rebuild-darwin: 2,501-5,000",
+                "10.rebuild-darwin: 5,001+",
                 "10.rebuild-linux: 1-10",
                 "10.rebuild-linux: 11-100",
                 "10.rebuild-linux: 101-500",
                 "10.rebuild-linux: 501+",
+                "10.rebuild-linux: 501-1,000",
+                "10.rebuild-linux: 1,001-2,500",
+                "10.rebuild-linux: 2,501-5,000",
+                "10.rebuild-linux: 5,001+",
             ]
         );
 
@@ -392,10 +424,18 @@ mod tests {
                 "10.rebuild-darwin: 11-100",
                 "10.rebuild-darwin: 101-500",
                 "10.rebuild-darwin: 501+",
+                "10.rebuild-darwin: 501-1,000",
+                "10.rebuild-darwin: 1,001-2,500",
+                "10.rebuild-darwin: 2,501-5,000",
+                "10.rebuild-darwin: 5,001+",
                 "10.rebuild-linux: 0",
                 "10.rebuild-linux: 11-100",
                 "10.rebuild-linux: 101-500",
                 "10.rebuild-linux: 501+",
+                "10.rebuild-linux: 501-1,000",
+                "10.rebuild-linux: 1,001-2,500",
+                "10.rebuild-linux: 2,501-5,000",
+                "10.rebuild-linux: 5,001+"
             ]
         );
 
@@ -412,10 +452,18 @@ mod tests {
                 "10.rebuild-darwin: 11-100",
                 "10.rebuild-darwin: 101-500",
                 "10.rebuild-darwin: 501+",
+                "10.rebuild-darwin: 501-1,000",
+                "10.rebuild-darwin: 1,001-2,500",
+                "10.rebuild-darwin: 2,501-5,000",
+                "10.rebuild-darwin: 5,001+",
                 "10.rebuild-linux: 0",
                 "10.rebuild-linux: 11-100",
                 "10.rebuild-linux: 101-500",
                 "10.rebuild-linux: 501+",
+                "10.rebuild-linux: 501-1,000",
+                "10.rebuild-linux: 1,001-2,500",
+                "10.rebuild-linux: 2,501-5,000",
+                "10.rebuild-linux: 5,001+"
             ]
         );
 
@@ -432,10 +480,18 @@ mod tests {
                 "10.rebuild-darwin: 11-100",
                 "10.rebuild-darwin: 101-500",
                 "10.rebuild-darwin: 501+",
+                "10.rebuild-darwin: 501-1,000",
+                "10.rebuild-darwin: 1,001-2,500",
+                "10.rebuild-darwin: 2,501-5,000",
+                "10.rebuild-darwin: 5,001+",
                 "10.rebuild-linux: 0",
                 "10.rebuild-linux: 11-100",
                 "10.rebuild-linux: 101-500",
                 "10.rebuild-linux: 501+",
+                "10.rebuild-linux: 501-1,000",
+                "10.rebuild-linux: 1,001-2,500",
+                "10.rebuild-linux: 2,501-5,000",
+                "10.rebuild-linux: 5,001+"
             ]
         );
 
@@ -452,10 +508,18 @@ mod tests {
                 "10.rebuild-darwin: 1-10",
                 "10.rebuild-darwin: 101-500",
                 "10.rebuild-darwin: 501+",
+                "10.rebuild-darwin: 501-1,000",
+                "10.rebuild-darwin: 1,001-2,500",
+                "10.rebuild-darwin: 2,501-5,000",
+                "10.rebuild-darwin: 5,001+",
                 "10.rebuild-linux: 0",
                 "10.rebuild-linux: 1-10",
                 "10.rebuild-linux: 101-500",
                 "10.rebuild-linux: 501+",
+                "10.rebuild-linux: 501-1,000",
+                "10.rebuild-linux: 1,001-2,500",
+                "10.rebuild-linux: 2,501-5,000",
+                "10.rebuild-linux: 5,001+"
             ]
         );
 
@@ -472,10 +536,18 @@ mod tests {
                 "10.rebuild-darwin: 1-10",
                 "10.rebuild-darwin: 101-500",
                 "10.rebuild-darwin: 501+",
+                "10.rebuild-darwin: 501-1,000",
+                "10.rebuild-darwin: 1,001-2,500",
+                "10.rebuild-darwin: 2,501-5,000",
+                "10.rebuild-darwin: 5,001+",
                 "10.rebuild-linux: 0",
                 "10.rebuild-linux: 1-10",
                 "10.rebuild-linux: 101-500",
                 "10.rebuild-linux: 501+",
+                "10.rebuild-linux: 501-1,000",
+                "10.rebuild-linux: 1,001-2,500",
+                "10.rebuild-linux: 2,501-5,000",
+                "10.rebuild-linux: 5,001+"
             ]
         );
 
@@ -492,10 +564,18 @@ mod tests {
                 "10.rebuild-darwin: 1-10",
                 "10.rebuild-darwin: 11-100",
                 "10.rebuild-darwin: 501+",
+                "10.rebuild-darwin: 501-1,000",
+                "10.rebuild-darwin: 1,001-2,500",
+                "10.rebuild-darwin: 2,501-5,000",
+                "10.rebuild-darwin: 5,001+",
                 "10.rebuild-linux: 0",
                 "10.rebuild-linux: 1-10",
                 "10.rebuild-linux: 11-100",
                 "10.rebuild-linux: 501+",
+                "10.rebuild-linux: 501-1,000",
+                "10.rebuild-linux: 1,001-2,500",
+                "10.rebuild-linux: 2,501-5,000",
+                "10.rebuild-linux: 5,001+"
             ]
         );
 
@@ -512,10 +592,18 @@ mod tests {
                 "10.rebuild-darwin: 1-10",
                 "10.rebuild-darwin: 11-100",
                 "10.rebuild-darwin: 501+",
+                "10.rebuild-darwin: 501-1,000",
+                "10.rebuild-darwin: 1,001-2,500",
+                "10.rebuild-darwin: 2,501-5,000",
+                "10.rebuild-darwin: 5,001+",
                 "10.rebuild-linux: 0",
                 "10.rebuild-linux: 1-10",
                 "10.rebuild-linux: 11-100",
                 "10.rebuild-linux: 501+",
+                "10.rebuild-linux: 501-1,000",
+                "10.rebuild-linux: 1,001-2,500",
+                "10.rebuild-linux: 2,501-5,000",
+                "10.rebuild-linux: 5,001+"
             ]
         );
 
@@ -523,19 +611,216 @@ mod tests {
         tagger.parse_attrs(PackageArchSrc::linux(501).and_darwin(501).into());
         assert_eq!(
             tagger.tags_to_add(),
-            vec!["10.rebuild-darwin: 501+", "10.rebuild-linux: 501+"]
+            vec![
+                "10.rebuild-darwin: 501+",
+                "10.rebuild-darwin: 501-1,000",
+                "10.rebuild-linux: 501+",
+                "10.rebuild-linux: 501-1,000",
+            ]
         );
         assert_eq!(
             tagger.tags_to_remove(),
             vec![
                 "10.rebuild-darwin: 0",
                 "10.rebuild-darwin: 1-10",
-                "10.rebuild-darwin: 101-500",
                 "10.rebuild-darwin: 11-100",
+                "10.rebuild-darwin: 101-500",
+                "10.rebuild-darwin: 1,001-2,500",
+                "10.rebuild-darwin: 2,501-5,000",
+                "10.rebuild-darwin: 5,001+",
                 "10.rebuild-linux: 0",
                 "10.rebuild-linux: 1-10",
-                "10.rebuild-linux: 101-500",
                 "10.rebuild-linux: 11-100",
+                "10.rebuild-linux: 101-500",
+                "10.rebuild-linux: 1,001-2,500",
+                "10.rebuild-linux: 2,501-5,000",
+                "10.rebuild-linux: 5,001+"
+            ]
+        );
+
+        let mut tagger = RebuildTagger::new();
+        tagger.parse_attrs(PackageArchSrc::linux(1000).and_darwin(1000).into());
+        assert_eq!(
+            tagger.tags_to_add(),
+            vec![
+                "10.rebuild-darwin: 501+",
+                "10.rebuild-darwin: 501-1,000",
+                "10.rebuild-linux: 501+",
+                "10.rebuild-linux: 501-1,000",
+            ]
+        );
+        assert_eq!(
+            tagger.tags_to_remove(),
+            vec![
+                "10.rebuild-darwin: 0",
+                "10.rebuild-darwin: 1-10",
+                "10.rebuild-darwin: 11-100",
+                "10.rebuild-darwin: 101-500",
+                "10.rebuild-darwin: 1,001-2,500",
+                "10.rebuild-darwin: 2,501-5,000",
+                "10.rebuild-darwin: 5,001+",
+                "10.rebuild-linux: 0",
+                "10.rebuild-linux: 1-10",
+                "10.rebuild-linux: 11-100",
+                "10.rebuild-linux: 101-500",
+                "10.rebuild-linux: 1,001-2,500",
+                "10.rebuild-linux: 2,501-5,000",
+                "10.rebuild-linux: 5,001+"
+            ]
+        );
+
+        let mut tagger = RebuildTagger::new();
+        tagger.parse_attrs(PackageArchSrc::linux(1001).and_darwin(1001).into());
+        assert_eq!(
+            tagger.tags_to_add(),
+            vec![
+                "10.rebuild-darwin: 501+",
+                "10.rebuild-darwin: 1,001-2,500",
+                "10.rebuild-linux: 501+",
+                "10.rebuild-linux: 1,001-2,500"
+            ]
+        );
+        assert_eq!(
+            tagger.tags_to_remove(),
+            vec![
+                "10.rebuild-darwin: 0",
+                "10.rebuild-darwin: 1-10",
+                "10.rebuild-darwin: 11-100",
+                "10.rebuild-darwin: 101-500",
+                "10.rebuild-darwin: 501-1,000",
+                "10.rebuild-darwin: 2,501-5,000",
+                "10.rebuild-darwin: 5,001+",
+                "10.rebuild-linux: 0",
+                "10.rebuild-linux: 1-10",
+                "10.rebuild-linux: 11-100",
+                "10.rebuild-linux: 101-500",
+                "10.rebuild-linux: 501-1,000",
+                "10.rebuild-linux: 2,501-5,000",
+                "10.rebuild-linux: 5,001+"
+            ]
+        );
+
+        let mut tagger = RebuildTagger::new();
+        tagger.parse_attrs(PackageArchSrc::linux(2500).and_darwin(2500).into());
+        assert_eq!(
+            tagger.tags_to_add(),
+            vec![
+                "10.rebuild-darwin: 501+",
+                "10.rebuild-darwin: 1,001-2,500",
+                "10.rebuild-linux: 501+",
+                "10.rebuild-linux: 1,001-2,500"
+            ]
+        );
+        assert_eq!(
+            tagger.tags_to_remove(),
+            vec![
+                "10.rebuild-darwin: 0",
+                "10.rebuild-darwin: 1-10",
+                "10.rebuild-darwin: 11-100",
+                "10.rebuild-darwin: 101-500",
+                "10.rebuild-darwin: 501-1,000",
+                "10.rebuild-darwin: 2,501-5,000",
+                "10.rebuild-darwin: 5,001+",
+                "10.rebuild-linux: 0",
+                "10.rebuild-linux: 1-10",
+                "10.rebuild-linux: 11-100",
+                "10.rebuild-linux: 101-500",
+                "10.rebuild-linux: 501-1,000",
+                "10.rebuild-linux: 2,501-5,000",
+                "10.rebuild-linux: 5,001+"
+            ]
+        );
+
+        let mut tagger = RebuildTagger::new();
+        tagger.parse_attrs(PackageArchSrc::linux(2501).and_darwin(2501).into());
+        assert_eq!(
+            tagger.tags_to_add(),
+            vec![
+                "10.rebuild-darwin: 501+",
+                "10.rebuild-darwin: 2,501-5,000",
+                "10.rebuild-linux: 501+",
+                "10.rebuild-linux: 2,501-5,000"
+            ]
+        );
+        assert_eq!(
+            tagger.tags_to_remove(),
+            vec![
+                "10.rebuild-darwin: 0",
+                "10.rebuild-darwin: 1-10",
+                "10.rebuild-darwin: 11-100",
+                "10.rebuild-darwin: 101-500",
+                "10.rebuild-darwin: 501-1,000",
+                "10.rebuild-darwin: 1,001-2,500",
+                "10.rebuild-darwin: 5,001+",
+                "10.rebuild-linux: 0",
+                "10.rebuild-linux: 1-10",
+                "10.rebuild-linux: 11-100",
+                "10.rebuild-linux: 101-500",
+                "10.rebuild-linux: 501-1,000",
+                "10.rebuild-linux: 1,001-2,500",
+                "10.rebuild-linux: 5,001+"
+            ]
+        );
+
+        let mut tagger = RebuildTagger::new();
+        tagger.parse_attrs(PackageArchSrc::linux(5000).and_darwin(5000).into());
+        assert_eq!(
+            tagger.tags_to_add(),
+            vec![
+                "10.rebuild-darwin: 501+",
+                "10.rebuild-darwin: 2,501-5,000",
+                "10.rebuild-linux: 501+",
+                "10.rebuild-linux: 2,501-5,000"
+            ]
+        );
+        assert_eq!(
+            tagger.tags_to_remove(),
+            vec![
+                "10.rebuild-darwin: 0",
+                "10.rebuild-darwin: 1-10",
+                "10.rebuild-darwin: 11-100",
+                "10.rebuild-darwin: 101-500",
+                "10.rebuild-darwin: 501-1,000",
+                "10.rebuild-darwin: 1,001-2,500",
+                "10.rebuild-darwin: 5,001+",
+                "10.rebuild-linux: 0",
+                "10.rebuild-linux: 1-10",
+                "10.rebuild-linux: 11-100",
+                "10.rebuild-linux: 101-500",
+                "10.rebuild-linux: 501-1,000",
+                "10.rebuild-linux: 1,001-2,500",
+                "10.rebuild-linux: 5,001+"
+            ]
+        );
+
+        let mut tagger = RebuildTagger::new();
+        tagger.parse_attrs(PackageArchSrc::linux(5001).and_darwin(5001).into());
+        assert_eq!(
+            tagger.tags_to_add(),
+            vec![
+                "10.rebuild-darwin: 501+",
+                "10.rebuild-darwin: 5,001+",
+                "10.rebuild-linux: 501+",
+                "10.rebuild-linux: 5,001+"
+            ]
+        );
+        assert_eq!(
+            tagger.tags_to_remove(),
+            vec![
+                "10.rebuild-darwin: 0",
+                "10.rebuild-darwin: 1-10",
+                "10.rebuild-darwin: 11-100",
+                "10.rebuild-darwin: 101-500",
+                "10.rebuild-darwin: 501-1,000",
+                "10.rebuild-darwin: 1,001-2,500",
+                "10.rebuild-darwin: 2,501-5,000",
+                "10.rebuild-linux: 0",
+                "10.rebuild-linux: 1-10",
+                "10.rebuild-linux: 11-100",
+                "10.rebuild-linux: 101-500",
+                "10.rebuild-linux: 501-1,000",
+                "10.rebuild-linux: 1,001-2,500",
+                "10.rebuild-linux: 2,501-5,000",
             ]
         );
     }

From 3f2b351901337778068ed09996b5641adfba7a91 Mon Sep 17 00:00:00 2001
From: Graham Christensen <graham@grahamc.com>
Date: Tue, 29 Jan 2019 22:10:57 -0500
Subject: [PATCH 4/4] fixup: clippy

---
 ofborg/src/tagger.rs | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/ofborg/src/tagger.rs b/ofborg/src/tagger.rs
index 7539942..112041b 100644
--- a/ofborg/src/tagger.rs
+++ b/ofborg/src/tagger.rs
@@ -117,7 +117,7 @@ pub struct RebuildTagger {
 
 impl Default for RebuildTagger {
     fn default() -> RebuildTagger {
-        let mut t = RebuildTagger {
+        RebuildTagger {
             possible: vec![
                 String::from("10.rebuild-darwin: 0"),
                 String::from("10.rebuild-darwin: 1-10"),
@@ -139,9 +139,7 @@ impl Default for RebuildTagger {
                 String::from("10.rebuild-linux: 5,001+"),
             ],
             selected: vec![],
-        };
-
-        t
+        }
     }
 }
 
@@ -359,7 +357,7 @@ mod tests {
 
     impl From<PackageArchSrc> for Vec<PackageArch> {
         fn from(src: PackageArchSrc) -> Vec<PackageArch> {
-            let mut darwin: Vec<PackageArch> = (0..src.darwin)
+            let darwin: Vec<PackageArch> = (0..src.darwin)
                 .into_iter()
                 .map(|_| PackageArch {
                     package: String::from("bogus :)"),