danderson/ofborg
0
0
Fork 0
forked from the-distro/ofborg
Code Pull requests Activity

buildresult.rs: use skipped instead of neutral for a skipped job

Browse source 
doesn't make much sense for a skipped job to be neutral
This commit is contained in:
Artturin 2022-04-02 04:07:53 +03:00 committed by Cole Helbling
parent db5293a4fb
commit b8077fc935
4 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Cargo.lock generated
View file

@ -566,7 +566,7 @@ checksum = "f3a87b616e37e93c22fb19bcd386f02f3af5ea98a25670ad0fce773de23c5e68"
[[package]] [[package]]
name = "hubcaps" name = "hubcaps"
version = "0.3.16" version = "0.3.16"
source = "git+https://github.com/grahamc/hubcaps.git#22ab34e2dc8804deebb5dd7ad9b796268f405780" source = "git+https://github.com/grahamc/hubcaps.git#de1e1521ee78b5df5e1435619c8e1b90c932d36b"
dependencies = [ dependencies = [
"error-chain", "error-chain",
"frank_jwt", "frank_jwt",

2
default.nix
View file

@ -34,7 +34,7 @@ let
cargoLock = { cargoLock = {
lockFile = ./Cargo.lock; lockFile = ./Cargo.lock;
outputHashes = { outputHashes = {
"hubcaps-0.3.16" = "sha256-fM0i8XTMyCuGtuHrhy1KNk+sJQ/clPnz4bjQkXkfslw="; "hubcaps-0.3.16" = "sha256-/BFXGccu27K8heK4IL7JnS/U7zatTk9wRybhtxppADM=";
}; };
}; };
}; };

2
ofborg/src/message/buildresult.rs
View file

@ -28,7 +28,7 @@ impl From<BuildStatus> for String {
impl From<BuildStatus> for Conclusion { impl From<BuildStatus> for Conclusion {
fn from(status: BuildStatus) -> Conclusion { fn from(status: BuildStatus) -> Conclusion {
match status { match status {
BuildStatus::Skipped => Conclusion::Neutral, BuildStatus::Skipped => Conclusion::Skipped,
BuildStatus::Success => Conclusion::Success, BuildStatus::Success => Conclusion::Success,
BuildStatus::Failure => Conclusion::Neutral, BuildStatus::Failure => Conclusion::Neutral,
BuildStatus::HashMismatch => Conclusion::Failure, BuildStatus::HashMismatch => Conclusion::Failure,

4
ofborg/src/tasks/githubcommentposter.rs
View file

@ -687,7 +687,7 @@ patching script interpreter paths in /nix/store/pcja75y9isdvgz5i00pkrpif9rxzxc29
started_at: None, started_at: None,
completed_at: Some("2023-04-20T13:37:42Z".to_string()), completed_at: Some("2023-04-20T13:37:42Z".to_string()),
status: Some(CheckRunState::Completed), status: Some(CheckRunState::Completed),
conclusion: Some(Conclusion::Neutral), conclusion: Some(Conclusion::Skipped),
details_url: Some("https://logs.nix.ci/?key=nixos/nixpkgs.2345&attempt_id=neatattemptid".to_string()), details_url: Some("https://logs.nix.ci/?key=nixos/nixpkgs.2345&attempt_id=neatattemptid".to_string()),
external_id: Some("neatattemptid".to_string()), external_id: Some("neatattemptid".to_string()),
head_sha: "abc123".to_string(), head_sha: "abc123".to_string(),
@ -740,7 +740,7 @@ foo
started_at: None, started_at: None,
completed_at: Some("2023-04-20T13:37:42Z".to_string()), completed_at: Some("2023-04-20T13:37:42Z".to_string()),
status: Some(CheckRunState::Completed), status: Some(CheckRunState::Completed),
conclusion: Some(Conclusion::Neutral), conclusion: Some(Conclusion::Skipped),
details_url: Some("https://logs.nix.ci/?key=nixos/nixpkgs.2345&attempt_id=neatattemptid".to_string()), details_url: Some("https://logs.nix.ci/?key=nixos/nixpkgs.2345&attempt_id=neatattemptid".to_string()),
external_id: Some("neatattemptid".to_string()), external_id: Some("neatattemptid".to_string()),
head_sha: "abc123".to_string(), head_sha: "abc123".to_string(),