danderson/ofborg
0
0
Fork 0
forked from the-distro/ofborg
Code Pull requests Activity

Use the attempt ID instead of the request ID for the check external ID

Browse source
This commit is contained in:
Graham Christensen 2018-11-30 20:59:48 -05:00
parent e41f707772
commit b33a1d23f8
No known key found for this signature in database
GPG key ID: ACA1C1D120C83D5C
1 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
ofborg/src/tasks/githubcommentposter.rs
View file

@ -148,7 +148,7 @@ fn result_to_check(result: &LegacyBuildResult) -> CheckRunOptions {
result.pr.number, result.pr.number,
result.attempt_id, result.attempt_id,
)), )),
external_id: Some(result.request_id.clone()), external_id: Some(result.attempt_id.clone()),
head_sha: result.pr.head_sha.clone(), head_sha: result.pr.head_sha.clone(),
output: Some(Output { output: Some(Output {
@ -668,7 +668,7 @@ No partial log is available.
status: Some(CheckRunState::Completed), status: Some(CheckRunState::Completed),
conclusion: Some(Conclusion::Success), conclusion: Some(Conclusion::Success),
details_url: Some("https://logs.nix.ci/?key=nixos/nixpkgs.2345&attempt_id=neatattemptid".to_string()), details_url: Some("https://logs.nix.ci/?key=nixos/nixpkgs.2345&attempt_id=neatattemptid".to_string()),
external_id: Some("bogus-request-id".to_string()), external_id: Some("neatattemptid".to_string()),
head_sha: "abc123".to_string(), head_sha: "abc123".to_string(),
output: Some(Output { output: Some(Output {
title: "Build Results".to_string(), title: "Build Results".to_string(),
@ -741,7 +741,7 @@ patching script interpreter paths in /nix/store/pcja75y9isdvgz5i00pkrpif9rxzxc29
status: Some(CheckRunState::Completed), status: Some(CheckRunState::Completed),
conclusion: Some(Conclusion::Neutral), conclusion: Some(Conclusion::Neutral),
details_url: Some("https://logs.nix.ci/?key=nixos/nixpkgs.2345&attempt_id=neatattemptid".to_string()), details_url: Some("https://logs.nix.ci/?key=nixos/nixpkgs.2345&attempt_id=neatattemptid".to_string()),
external_id: Some("bogus-request-id".to_string()), external_id: Some("neatattemptid".to_string()),
head_sha: "abc123".to_string(), head_sha: "abc123".to_string(),
output: Some(Output { output: Some(Output {
title: "Build Results".to_string(), title: "Build Results".to_string(),
@ -811,7 +811,7 @@ patching script interpreter paths in /nix/store/pcja75y9isdvgz5i00pkrpif9rxzxc29
status: Some(CheckRunState::Completed), status: Some(CheckRunState::Completed),
conclusion: Some(Conclusion::Neutral), conclusion: Some(Conclusion::Neutral),
details_url: Some("https://logs.nix.ci/?key=nixos/nixpkgs.2345&attempt_id=neatattemptid".to_string()), details_url: Some("https://logs.nix.ci/?key=nixos/nixpkgs.2345&attempt_id=neatattemptid".to_string()),
external_id: Some("bogus-request-id".to_string()), external_id: Some("neatattemptid".to_string()),
head_sha: "abc123".to_string(), head_sha: "abc123".to_string(),
output: Some(Output { output: Some(Output {
title: "Build Results".to_string(), title: "Build Results".to_string(),
@ -882,7 +882,7 @@ error: build of '/nix/store/l1limh50lx2cx45yb2gqpv7k8xl1mik2-gdb-8.1.drv' failed
status: Some(CheckRunState::Completed), status: Some(CheckRunState::Completed),
conclusion: Some(Conclusion::Success), conclusion: Some(Conclusion::Success),
details_url: Some("https://logs.nix.ci/?key=nixos/nixpkgs.2345&attempt_id=neatattemptid".to_string()), details_url: Some("https://logs.nix.ci/?key=nixos/nixpkgs.2345&attempt_id=neatattemptid".to_string()),
external_id: Some("bogus-request-id".to_string()), external_id: Some("neatattemptid".to_string()),
head_sha: "abc123".to_string(), head_sha: "abc123".to_string(),
output: Some(Output { output: Some(Output {
title: "Build Results".to_string(), title: "Build Results".to_string(),
@ -952,7 +952,7 @@ patching script interpreter paths in /nix/store/pcja75y9isdvgz5i00pkrpif9rxzxc29
status: Some(CheckRunState::Completed), status: Some(CheckRunState::Completed),
conclusion: Some(Conclusion::Neutral), conclusion: Some(Conclusion::Neutral),
details_url: Some("https://logs.nix.ci/?key=nixos/nixpkgs.2345&attempt_id=neatattemptid".to_string()), details_url: Some("https://logs.nix.ci/?key=nixos/nixpkgs.2345&attempt_id=neatattemptid".to_string()),
external_id: Some("bogus-request-id".to_string()), external_id: Some("neatattemptid".to_string()),
head_sha: "abc123".to_string(), head_sha: "abc123".to_string(),
output: Some(Output { output: Some(Output {
title: "Build Results".to_string(), title: "Build Results".to_string(),
@ -993,7 +993,7 @@ patching script interpreter paths in /nix/store/pcja75y9isdvgz5i00pkrpif9rxzxc29
target_branch: Some("master".to_owned()), target_branch: Some("master".to_owned()),
}, },
output: vec!["foo".to_owned()], output: vec!["foo".to_owned()],
attempt_id: "foo".to_owned(), attempt_id: "neatattemptid".to_owned(),
request_id: "bogus-request-id".to_owned(), request_id: "bogus-request-id".to_owned(),
system: "x86_64-linux".to_owned(), system: "x86_64-linux".to_owned(),
attempted_attrs: None, attempted_attrs: None,
@ -1010,8 +1010,8 @@ patching script interpreter paths in /nix/store/pcja75y9isdvgz5i00pkrpif9rxzxc29
completed_at: Some("2018-01-01T01:01:01Z".to_string()), completed_at: Some("2018-01-01T01:01:01Z".to_string()),
status: Some(CheckRunState::Completed), status: Some(CheckRunState::Completed),
conclusion: Some(Conclusion::Neutral), conclusion: Some(Conclusion::Neutral),
details_url: Some("https://logs.nix.ci/?key=nixos/nixpkgs.2345&attempt_id=foo".to_string()), details_url: Some("https://logs.nix.ci/?key=nixos/nixpkgs.2345&attempt_id=neatattemptid".to_string()),
external_id: Some("bogus-request-id".to_string()), external_id: Some("neatattemptid".to_string()),
head_sha: "abc123".to_string(), head_sha: "abc123".to_string(),
output: Some(Output { output: Some(Output {
title: "Build Results".to_string(), title: "Build Results".to_string(),
@ -1044,7 +1044,7 @@ foo
target_branch: Some("master".to_owned()), target_branch: Some("master".to_owned()),
}, },
output: vec![], output: vec![],
attempt_id: "foo".to_owned(), attempt_id: "neatattemptid".to_owned(),
request_id: "bogus-request-id".to_owned(), request_id: "bogus-request-id".to_owned(),
system: "x86_64-linux".to_owned(), system: "x86_64-linux".to_owned(),
attempted_attrs: None, attempted_attrs: None,
@ -1061,8 +1061,8 @@ foo
completed_at: Some("2018-01-01T01:01:01Z".to_string()), completed_at: Some("2018-01-01T01:01:01Z".to_string()),
status: Some(CheckRunState::Completed), status: Some(CheckRunState::Completed),
conclusion: Some(Conclusion::Neutral), conclusion: Some(Conclusion::Neutral),
details_url: Some("https://logs.nix.ci/?key=nixos/nixpkgs.2345&attempt_id=foo".to_string()), details_url: Some("https://logs.nix.ci/?key=nixos/nixpkgs.2345&attempt_id=neatattemptid".to_string()),
external_id: Some("bogus-request-id".to_string()), external_id: Some("neatattemptid".to_string()),
head_sha: "abc123".to_string(), head_sha: "abc123".to_string(),
output: Some(Output { output: Some(Output {
title: "Build Results".to_string(), title: "Build Results".to_string(),