danderson/ofborg
0
0
Fork 0
forked from the-distro/ofborg
Code Pull requests Activity

tasks/eval/nixpkgs: don't request review from PR author

Browse source 
GitHub doesn't let us, so we silently skip them.
This commit is contained in:
Cole Helbling 2020-04-07 13:12:49 -07:00
parent 8e284c5b6b
commit 5fd48be23d
No known key found for this signature in database
GPG key ID: B37E0F2371016A4C
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
ofborg/src/tasks/eval/nixpkgs.rs
View file

@ -566,8 +566,18 @@ impl<'a> EvaluationStrategy for NixpkgsStrategy<'a> {
}
fn request_reviews(maint: &maintainers::ImpactedMaintainers, pull: &hubcaps::pulls::PullRequest) {
let pull_meta = pull.get();
if maint.maintainers().len() < 10 {
for maintainer in maint.maintainers() {
if let Ok(meta) = &pull_meta {
// GitHub doesn't let us request a review from the PR author, so
// we silently skip them.
if meta.user.login.to_ascii_lowercase() == maintainer.to_ascii_lowercase() {
continue;
}
}
if let Err(e) =
pull.review_requests()
.create(&hubcaps::review_requests::ReviewRequestOptions {