bbjubjub2494/lix
0
0
Fork 0
forked from lix-project/lix
Code Pull requests Activity
lix/src/libstore
History
aszlig 525b38eee8
Fix unspecified behaviour in readStorePathCAMap 
When deploying a Hydra instance with current Nix master, most builds
would not run because of errors like this:

  queue monitor: error: --- Error --- hydra-queue-runner
  error: --- UsageError --- nix-daemon
  not a content address because it is not in the form '<prefix>:<rest>': /nix/store/...-somedrv

The last error message is from parseContentAddress, which expects a
colon-separated string, however what we got here is a store path.

Looking at the worker protocol, the following message sent to the Nix
daemon caused the error above:

  0x1E -> wopQuerySubstitutablePathInfos
  0x01 -> Number of paths
  0x16 -> Length of string
  "/nix/store/...-somedrv"
  0x00 -> Length of string
  ""

Looking at writeStorePathCAMap, the store path is indeed the first field
that's transmitted. However, readStorePathCAMap expects it to be the
*second* field *on my machine*, since expression evaluation order is a
classic form of unspecified behaviour[1] in C++.

This has been introduced in https://github.com/NixOS/nix/pull/3689,
specifically in commit 66a62b3189.

[1]: https://en.wikipedia.org/wiki/Unspecified_behavior#Order_of_evaluation_of_subexpressions

Signed-off-by: aszlig <aszlig@nix.build>
2020-09-13 02:40:51 +02:00
..
builtins Fix build 2020-08-06 21:04:31 -05:00
binary-cache-store.cc Merge pull request #3899 from obsidiansystems/make-narHash-not-optional 2020-08-14 17:00:18 +02:00
binary-cache-store.hh Make 'nix copy' to s3:// binary caches run in constant memory 2020-07-13 20:07:19 +02:00
build.cc Merge pull request #3859 from obsidiansystems/drv-outputs-map-allow-missing 2020-08-20 16:49:23 +02:00
builtins.hh buildenv: Eliminate global variables, other cleanup 2020-03-24 14:06:47 +01:00
content-address.cc Merge branch 'misc-ca' of https://github.com/obsidiansystems/nix 2020-08-05 16:50:05 +02:00
content-address.hh Factor out commonality between nix-prefetch-url and nix-store --add-fixed 2020-07-10 13:21:37 +02:00
crypto.cc binary-cache-public-keys -> trusted-public-keys 2017-11-20 17:32:34 +01:00
crypto.hh Revert "Get rid of unicode quotes (#1140)" 2016-11-26 00:38:01 +01:00
daemon.cc Merge pull request #3859 from obsidiansystems/drv-outputs-map-allow-missing 2020-08-20 16:49:23 +02:00
daemon.hh Separate auth and logic for the daemon 2020-08-12 15:22:33 +00:00
derivations.cc Merge pull request #3434 from Ericson2314/derivation-header-include-order 2020-08-27 16:39:28 +02:00
derivations.hh Merge pull request #3434 from Ericson2314/derivation-header-include-order 2020-08-27 16:39:28 +02:00
dummy-store.cc Add DummyStore (dummy://) 2020-08-24 18:54:16 +02:00
export-import.cc Minimize the usage of Hash::dummy 2020-08-06 18:31:48 +00:00
filetransfer.cc Use heuristics to decide when to show the response 2020-07-20 15:57:58 -04:00
filetransfer.hh Generate the nix.conf docs from the source code 2020-08-19 18:28:04 +02:00
fs-accessor.hh Shut up some warnings 2019-09-22 21:57:05 +02:00
gc.cc Remove gc-check-reachability 2020-09-03 11:30:15 +02:00
globals.cc Config: Use nlohmann/json 2020-08-20 11:02:16 +02:00
globals.hh Remove gc-check-reachability 2020-09-03 11:30:15 +02:00
http-binary-cache-store.cc Allow HTTP binary cache to request absolute uris 2020-09-01 21:35:48 +02:00
legacy-ssh-store.cc Merge pull request #3930 from obsidiansystems/legacy-ssh-build-paths 2020-08-18 16:07:40 +02:00
local-binary-cache-store.cc Make 'nix copy' to s3:// binary caches run in constant memory 2020-07-13 20:07:19 +02:00
local-fs-store.cc toStorePath(): Return a StorePath and the suffix 2020-07-13 16:25:48 +02:00
local-store.cc Merge pull request #3859 from obsidiansystems/drv-outputs-map-allow-missing 2020-08-20 16:49:23 +02:00
local-store.hh Merge pull request #3434 from Ericson2314/derivation-header-include-order 2020-08-27 16:39:28 +02:00
local.mk Merge remote-tracking branch 'origin/master' into flakes 2020-06-17 10:26:52 +02:00
machines.cc Make system-features a store setting 2020-08-12 18:13:00 +00:00
machines.hh Make system-features a store setting 2020-08-12 18:13:00 +00:00
misc.cc Merge branch 'master' of github.com:NixOS/nix into new-interface-for-path-pathOpt 2020-08-05 15:45:33 -04:00
names.cc Move names.{cc,hh} to libstore 2020-06-11 15:42:18 +02:00
names.hh Move names.{cc,hh} to libstore 2020-06-11 15:42:18 +02:00
nar-accessor.cc Merge remote-tracking branch 'origin/master' into markdown 2020-07-31 16:07:04 +02:00
nar-accessor.hh NarAccessor: Run in constant memory 2020-07-13 17:30:42 +02:00
nar-info-disk-cache.cc Minimize the usage of Hash::dummy 2020-08-06 18:31:48 +00:00
nar-info-disk-cache.hh Misc changes from the flakes branch 2020-03-24 14:34:47 +01:00
nar-info.cc Minimize the usage of Hash::dummy 2020-08-06 18:31:48 +00:00
nar-info.hh Minimize the usage of Hash::dummy 2020-08-06 18:31:48 +00:00
nix-store.pc.in pkg-config files: Use c++17 2019-03-14 14:11:12 +01:00
optimise-store.cc unsigned long long -> uint64_t 2020-07-30 13:34:04 +02:00
parsed-derivations.cc Make system-features a store setting 2020-08-12 18:13:00 +00:00
parsed-derivations.hh Make system-features a store setting 2020-08-12 18:13:00 +00:00
path-info.hh Minimize the usage of Hash::dummy 2020-08-06 18:31:48 +00:00
path.cc toStorePath(): Return a StorePath and the suffix 2020-07-13 16:25:48 +02:00
path.hh Merge remote-tracking branch 'origin/master' into substitute-other-storedir 2020-07-02 11:14:04 -04:00
pathlocks.cc convert some printError calls to logError 2020-05-03 08:01:25 -06:00
pathlocks.hh Use BSD instead of POSIX file locks 2019-08-02 18:39:16 +02:00
profiles.cc addPermRoot(): Remove indirect flag 2020-09-03 11:29:34 +02:00
profiles.hh createGeneration(): Take a StorePath 2020-09-03 11:06:56 +02:00
references.cc Merge remote-tracking branch 'upstream/master' into hash-always-has-type 2020-07-27 14:22:45 +00:00
references.hh WIP: Make Hash always store a valid hash type 2020-06-19 21:48:57 +00:00
remote-fs-accessor.cc toStorePath(): Return a StorePath and the suffix 2020-07-13 16:25:48 +02:00
remote-fs-accessor.hh toStorePath(): Return a StorePath and the suffix 2020-07-13 16:25:48 +02:00
remote-store.cc Fix unspecified behaviour in readStorePathCAMap 2020-09-13 02:40:51 +02:00
remote-store.hh RemoteStore::addToStore(): Fix race between stderrThread and NAR writer 2020-08-27 14:50:51 +02:00
s3-binary-cache-store.cc S3BinaryCacheStore: Fix size determination 2020-08-04 16:01:13 +02:00
s3-binary-cache-store.hh Revert "Remove putBytes" 2020-08-04 15:56:10 +02:00
s3.hh DataTransfer -> FileTransfer 2020-04-08 22:26:57 +02:00
sandbox-defaults.sb sandbox: fix /bin/sh on catalina 2020-03-20 22:12:30 +01:00
sandbox-minimal.sb Always use the Darwin sandbox 2017-06-06 18:44:49 +02:00
sandbox-network.sb OS X sandbox: Improve builtin sandbox profile 2017-05-31 17:25:51 +02:00
schema.sql Mark content-addressed paths in the Nix database and in .narinfo 2016-08-10 18:05:35 +02:00
serve-protocol.hh Make adding paths via nix-store --serve run in constant memory 2018-08-03 21:21:16 +02:00
sqlite.cc Merge remote-tracking branch 'origin/master' into flakes 2020-06-17 10:26:52 +02:00
sqlite.hh Merge remote-tracking branch 'origin/master' into flakes 2020-06-17 10:26:52 +02:00
ssh-store.cc Fix segfault in gcc on i686-linux 2020-02-07 13:01:48 +01:00
ssh.cc Revert the enum struct change 2020-06-18 22:11:26 +00:00
ssh.hh SSHMaster: Bypass SSH when connecting to localhost 2018-08-03 21:20:38 +02:00
store-api.cc Merge pull request #3434 from Ericson2314/derivation-header-include-order 2020-08-27 16:39:28 +02:00
store-api.hh addPermRoot(): Remove indirect flag 2020-09-03 11:29:34 +02:00
worker-protocol.hh Merge pull request #3859 from obsidiansystems/drv-outputs-map-allow-missing 2020-08-20 16:49:23 +02:00