artemist/lix
0
0
Fork 0
forked from lix-project/lix
Code Pull requests Activity

Remove unnecessary call to closeMostFDs()

Browse source 
We have close-on-exec on all FDs now, and there is no security risk in
passing open FDs to substituters anyway.
This commit is contained in:
Eelco Dolstra 2012-11-09 14:43:47 +01:00
parent a9a8baaccb
commit 91ef4d9a81
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/libstore/local-store.cc
View file

@ -983,7 +983,6 @@ void LocalStore::startSubstituter(const Path & substituter, RunningSubstituter &
throw SysError("dupping stdout"); throw SysError("dupping stdout");
if (dup2(errorPipe.writeSide, STDERR_FILENO) == -1) if (dup2(errorPipe.writeSide, STDERR_FILENO) == -1)
throw SysError("dupping stderr"); throw SysError("dupping stderr");
closeMostFDs(set<int>());
execl(substituter.c_str(), substituter.c_str(), "--query", NULL); execl(substituter.c_str(), substituter.c_str(), "--query", NULL);
throw SysError(format("executing `%1%'") % substituter); throw SysError(format("executing `%1%'") % substituter);
} catch (std::exception & e) { } catch (std::exception & e) {