artemist/lix
0
0
Fork 0
forked from lix-project/lix
Code Pull requests Activity

Add primops all and any

Browse source 
These are used thousands of times during NixOS evaluation, so it's
useful to speed them up.
This commit is contained in:
Eelco Dolstra 2015-07-23 19:23:11 +02:00
parent 39e27a04b8
commit 14be783676
4 changed files with 67 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
doc/manual/expressions/builtins.xml
View file

@ -39,6 +39,28 @@ available as <function>builtins.derivation</function>.</para>
</varlistentry> </varlistentry>
<varlistentry><term><function>builtins.all</function>
<replaceable>pred</replaceable> <replaceable>list</replaceable></term>
<listitem><para>Return <literal>true</literal> if the function
<replaceable>pred</replaceable> returns <literal>true</literal>
for all elements of <replaceable>list</replaceable>,
and <literal>false</literal> otherwise.</para></listitem>
</varlistentry>
<varlistentry><term><function>builtins.any</function>
<replaceable>pred</replaceable> <replaceable>list</replaceable></term>
<listitem><para>Return <literal>true</literal> if the function
<replaceable>pred</replaceable> returns <literal>true</literal>
for at least one element of <replaceable>list</replaceable>,
and <literal>false</literal> otherwise.</para></listitem>
</varlistentry>
<varlistentry><term><function>builtins.attrNames</function> <varlistentry><term><function>builtins.attrNames</function>
<replaceable>set</replaceable></term> <replaceable>set</replaceable></term>

33
src/libexpr/primops.cc
View file

@ -1333,6 +1333,37 @@ static void prim_foldlStrict(EvalState & state, const Pos & pos, Value * * args,
} }
static void anyOrAll(bool any, EvalState & state, const Pos & pos, Value * * args, Value & v)
{
state.forceFunction(*args[0], pos);
state.forceList(*args[1], pos);
Value vTmp;
for (unsigned int n = 0; n < args[1]->list.length; ++n) {
state.callFunction(*args[0], *args[1]->list.elems[n], vTmp, pos);
bool res = state.forceBool(vTmp);
if (res == any) {
mkBool(v, any);
return;
}
}
mkBool(v, !any);
}
static void prim_any(EvalState & state, const Pos & pos, Value * * args, Value & v)
{
anyOrAll(true, state, pos, args, v);
}
static void prim_all(EvalState & state, const Pos & pos, Value * * args, Value & v)
{
anyOrAll(false, state, pos, args, v);
}
/************************************************************* /*************************************************************
* Integer arithmetic * Integer arithmetic
*************************************************************/ *************************************************************/
@ -1671,6 +1702,8 @@ void EvalState::createBaseEnv()
addPrimOp("__concatLists", 1, prim_concatLists); addPrimOp("__concatLists", 1, prim_concatLists);
addPrimOp("__length", 1, prim_length); addPrimOp("__length", 1, prim_length);
addPrimOp("__foldl'", 3, prim_foldlStrict); addPrimOp("__foldl'", 3, prim_foldlStrict);
addPrimOp("__any", 2, prim_any);
addPrimOp("__all", 2, prim_all);
// Integer arithmetic // Integer arithmetic
addPrimOp("__add", 2, prim_add); addPrimOp("__add", 2, prim_add);

1
tests/lang/eval-okay-any-all.exp Normal file
View file

@ -0,0 +1 @@
[ false false true true true true false true ]

11
tests/lang/eval-okay-any-all.nix Normal file
View file

@ -0,0 +1,11 @@
with builtins;
[ (any (x: x == 1) [])
(any (x: x == 1) [2 3 4])
(any (x: x == 1) [1 2 3 4])
(any (x: x == 1) [4 3 2 1])
(all (x: x == 1) [])
(all (x: x == 1) [1])
(all (x: x == 1) [1 2 3])
(all (x: x == 1) [1 1 1])
]