forked from lix-project/lix
Maximilian Bosch
35eec921af
The original idea was to fix lix#174, but for a user friendly solution,
I figured that we'd need more consistency:
* Invalid query params will cause an error, just like invalid
attributes. This has the following two consequences:
* The `?dir=`-param from flakes will be removed before the URL to be
fetched is passed to libfetchers.
* The tarball fetcher doesn't allow URLs with custom query params
anymore. I think this was questionable anyways given that an
arbitrary set of query params was silently removed from the URL you
wanted to fetch. The correct way is to use an attribute-set
with a key `url` that contains the tarball URL to fetch.
* Same for the git & mercurial fetchers: in that case it doesn't even
matter though: both fetchers added unused query params to the URL
that's passed from the input scheme to the fetcher (`url2` in the code).
It turns out that this was never used since the query parameters were
erased again in `getActualUrl`.
* Validation happens for both attributes and URLs. Previously, a lot of
fetchers validated e.g. refs/revs only when specified in a URL and
the validity of attribute names only in `inputFromAttrs`.
Now, all the validation is done in `inputFromAttrs` and `inputFromURL`
constructs attributes that will be passed to `inputFromAttrs`.
* Accept all attributes as URL query parameters. That also includes
lesser used ones such as `narHash`.
And "output" attributes like `lastModified`: these could be declared
already when declaring inputs as attribute rather than URL. Now the
behavior is at least consistent.
Personally, I think we should differentiate in the future between
"fetched input" (basically the attr-set that ends up in the lock-file)
and "unfetched input" earlier: both inputFrom{Attrs,URL} entrypoints
are probably OK for unfetched inputs, but for locked/fetched inputs
a custom entrypoint should be used. Then, the current entrypoints
wouldn't have to allow these attributes anymore.
Change-Id:
|
||
|---|---|---|
| .. | ||
| ca-fd-leak | ||
| containers | ||
| coredumps | ||
| fetch-git | ||
| no-new-privileges | ||
| setuid | ||
| authorization.nix | ||
| broken-userns.nix | ||
| default.nix | ||
| github-flakes.nix | ||
| nix-copy-closure.nix | ||
| nix-copy.nix | ||
| nix-upgrade-nix.nix | ||
| nss-preload.nix | ||
| remote-builds-ssh-ng.nix | ||
| remote-builds.nix | ||
| sourcehut-flakes.nix | ||
| symlink-resolvconf.nix | ||
| tarball-flakes.nix | ||
| util.nix | ||