forked from lix-project/lix
Linus Heckemann
78ac3eb4eb
nix-store --export, nix-store --dump, and nix dump-path would previously
fail silently if writing the data out failed, because
a) FdSink::write ignored exceptions, and
b) the commands relied on FdSink's destructor, which ignores
exceptions, to flush the data out.
This could cause rather opaque issues with installing nixos, because
nix-store --export would happily proceed even if it couldn't write its
data out (e.g. if nix-store --import on the other side of the pipe
failed).
This commit adds tests that expose these issues in the nix-store
commands, and fixes them for all three.
37 lines
841 B
C++
37 lines
841 B
C++
#include "command.hh"
|
|
#include "store-api.hh"
|
|
|
|
using namespace nix;
|
|
|
|
struct CmdDumpPath : StorePathCommand
|
|
{
|
|
std::string name() override
|
|
{
|
|
return "dump-path";
|
|
}
|
|
|
|
std::string description() override
|
|
{
|
|
return "dump a store path to stdout (in NAR format)";
|
|
}
|
|
|
|
Examples examples() override
|
|
{
|
|
return {
|
|
Example{
|
|
"To get a NAR from the binary cache https://cache.nixos.org/:",
|
|
"nix dump-path --store https://cache.nixos.org/ /nix/store/7crrmih8c52r8fbnqb933dxrsp44md93-glibc-2.25"
|
|
},
|
|
};
|
|
}
|
|
|
|
void run(ref<Store> store, const Path & storePath) override
|
|
{
|
|
FdSink sink(STDOUT_FILENO);
|
|
store->narFromPath(storePath, sink);
|
|
sink.flush();
|
|
}
|
|
};
|
|
|
|
static RegisterCommand r1(make_ref<CmdDumpPath>());
|